Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn not to include URL instead of domain and port #1811

Merged
merged 1 commit into from
Oct 23, 2022
Merged

Warn not to include URL instead of domain and port #1811

merged 1 commit into from
Oct 23, 2022

Conversation

mdoro-113
Copy link
Contributor

@mdoro-113 mdoro-113 commented Oct 4, 2022 •
edited
Loading

Description

Added a warning not to include the URL instead of the actual domain in the --whitelist-domain argument.

Motivation and Context

Passing the URL instead of the domain/port is an easy mistake to make and some people may waste a lot of time trying to find the problem.

Checklist:

  • [ x] My change requires a change to the documentation or CHANGELOG.
  • [x ] I have updated the documentation/CHANGELOG accordingly.
  • I have created a feature (non-master) branch for my PR.

@mdoro-113 mdoro-113 requested a review from a team as a code owner October 4, 2022 15:44
JoelSpeed
JoelSpeed approved these changes Oct 22, 2022
View reviewed changes
Copy link
Member

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good update, thanks

@JoelSpeed JoelSpeed merged commit cfcba1a into oauth2-proxy:master Oct 23, 2022
@mdoro-113 mdoro-113 deleted the warn_about_potential_mistake_in_whitelist-domain branch October 24, 2022 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelSpeed JoelSpeed JoelSpeed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdoro-113 @JoelSpeed