Inconsistent code-challenge-method CLI flag and config file naming #1766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allow previous config option for now to prevent breaking configs Fixes oauth2-proxy#1667
JoelSpeed
previously approved these changes
Aug 31, 2022
There was a problem hiding this comment.
Hey @braunsonm, this looks good, can you add a changelog and then feel free to merge
|
My fault @JoelSpeed I thought I had added that. I don't have permission to merge so when you get a chance please go ahead. |
msaf1980
pushed a commit
to msaf1980/oauth2-proxy
that referenced
this pull request
Sep 27, 2022
…auth2-proxy#1766) * Inconsistent code-challenge-method CLI flag and config file naming - Allow previous config option for now to prevent breaking configs Fixes oauth2-proxy#1667 * Add changelog entry Co-authored-by: Joel Speed <Joel.speed@hotmail.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1667
Description
See #1667
How Has This Been Tested?
Locally with contrib
Checklist: