Update golangci-lint to latest version (v1.36.0) #1052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoelSpeed
commented
Feb 17, 2021
Comment on lines
+808
to
+809
| // TODO(@NickMeves): Remove once all provider are updated to implement EnrichSession | ||
| // nolint:staticcheck |
There was a problem hiding this comment.
Since the rest of the Todos are marked for you @NickMeves, I think it makes sense to continue with that 😉
| TLSClientConfig: &tls.Config{ | ||
| RootCAs: pool, | ||
| }, | ||
| transport := http.DefaultTransport.(*http.Transport).Clone() |
There was a problem hiding this comment.
This is a random optimisation I've included so we use the default config and only override the bits we need
JoelSpeed
force-pushed
the
update-linter
branch
from
4d6d340 to
9cea4ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update golangci-lint to v1.36.0 and fix the new linting things it's complaining about
Motivation and Context
It hasn't been updated in the while and I recently setup a new machine, which had different issues to what I was seeing in CI
How Has This Been Tested?
make lintChecklist: