Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gitlab version warning/constaint in documentation #1004

Merged
merged 1 commit into from
Jan 20, 2021
Merged

Add Gitlab version warning/constaint in documentation #1004

merged 1 commit into from
Jan 20, 2021

Conversation

papey
Copy link
Contributor

@papey papey commented Jan 20, 2021

Description

Doc update to warn users about minimal Gitlab version requirements for the Gitlab OAuth provider.

Motivation and Context

This is caused by issue #994. The added note will be useful to prevent more issue like the one mentioned.

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation or CHANGELOG.
  • I have updated the documentation/CHANGELOG accordingly.
  • I have created a feature (non-master) branch for my PR.

@NickMeves

@papey papey requested a review from a team as a code owner January 20, 2021 16:42
Copy link
Member

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@JoelSpeed JoelSpeed merged commit 8087de7 into oauth2-proxy:master Jan 20, 2021
k-jell pushed a commit to liquidinvestigations/oauth2-proxy that referenced this pull request Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants