Visual Voice Activity Detection (VVAD) integration including live camera and prerecorded demo #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed small bug in framerate reduction
oarriaga
reviewed
Apr 12, 2024
paz/processors/standard.py
Outdated
Comment on lines
586
to
607
| if value is None: | ||
| mean = None | ||
| else: | ||
| size = len(self.predictions) | ||
|
|
||
| self.predictions.append(value) | ||
| if size > self.window_size: | ||
| self.predictions.pop(0) | ||
|
|
||
| mean = 0 | ||
| if len(self.predictions) <= 1: | ||
| mean = value | ||
| else: | ||
| total_weights = 0 | ||
| for prediction_index in range(0, size): | ||
| weight = (prediction_index + 1) / size | ||
| mean = mean + self.predictions[prediction_index] * weight | ||
| total_weights = total_weights + weight | ||
| mean = mean / total_weights | ||
| return mean | ||
|
|
||
|
|
There was a problem hiding this comment.
I think this can be split into smaller functions to improve readability. The 3 conditions + for loop in a call seems to complex to read and understand easily.
There was a problem hiding this comment.
I have combined the AveragePredictions class with the WeightedAveragePredictions class. Additionally, I moved the computation of the weighted average (the for loop) to the backend.
For me it looks more readable now and I could save duplicated lines :)
added 4 commits
April 12, 2024 19:21
…tion_to_paz # Conflicts: # paz/backend/standard.py # paz/processors/__init__.py # paz/processors/standard.py
oarriaga
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes:
Note: