Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NonMaximumSuppression processor changed #282

Merged
merged 47 commits into from
May 26, 2023
Merged

NonMaximumSuppression processor changed #282

merged 47 commits into from
May 26, 2023

Conversation

Manojkumarmuru
Copy link
Contributor

  • NonMaximumSuppression now additionally returns class_labels.
  • New processor MergeNMSBoxesWithClass made.
  • Code refactored.
  • Docstrings elaborated.
  • Issues with processors used in Postproccess fixed, hence SSD300 achieves an mAP of 0.7513. (However, new training has to be run).
  • Unit tests for nms_per_class() and merge_box_with_class() has been made.
  • Documentation updated.
  • All test cases pass.

Manojkumarmuru and others added 30 commits February 24, 2023 01:01
@Manojkumarmuru
Update README.md
7a8a2fd
@Manojkumarmuru
Merge branch 'oarriaga:master' into master
186d302
@Manojkumarmuru
Updated branch
a92c68f
@Manojkumarmuru
NonMaximumSuppression processor now returns class_labels that improve…
7921d66 
…s the mAP of SSD300 to 0.75
@Manojkumarmuru
Temporary fix and requires refactoring
a63ec82
@Manojkumarmuru
Merge branch 'oarriaga:master' into master
1c7f5ca
@Manojkumarmuru
Filtering confident detections removed from NonMaximumSuppression and…
331acb6 
… put inside separate processor
@Manojkumarmuru
FilterBoxes processor added to efficientdetPostprocess
089c607
@Manojkumarmuru
Unused conf_thresh removed from nms_per_class
2e4381d
@Manojkumarmuru
Basic refactoring
7081040
@Manojkumarmuru
nms_per_class() renamed to nms()
4015ffc
@Manojkumarmuru
nms_per_class() function refactored
8a13486
@Manojkumarmuru
Minor refactoring
99018d7
@Manojkumarmuru
Minor refactoring
3505321
@Manojkumarmuru
Added docstrings
1373f64
@Manojkumarmuru
Minor refactoring to make the variables more explicit
7195442
@Manojkumarmuru
If else block removed and refactored
04478a2
@Manojkumarmuru
If else block removed and refactored
ecf5ace
@Manojkumarmuru
Static arguments packed in args variable
3e501c6
@Manojkumarmuru
Old nms_per_class renamed to _nms_per_class and old nms renamed to nm…
def8f91 
…s_per_class, docstrings made more informative
@Manojkumarmuru
Merge branch 'master' of https://github.com/Manojkumarmuru/paz into e…
695ac4b 
…fficientdet
@Manojkumarmuru
The intial score filtering performed inside _nms_per_class() function…
317a268 
… is put inside a separate function called pre_filter_nms
@Manojkumarmuru
MergeBoxWithClass processor added that is applied between NonMaximumS…
9a8d854 
…uppression and FilterBoxes
@Manojkumarmuru
MergeBoxWithClass processor added to EfficientDet post processing
e6162b6
@Manojkumarmuru
all_row renamed to all_rows
e6fab72
@Manojkumarmuru
Docstring added to MergeBoxWithClass processor
cdfafbf
@Manojkumarmuru
Docstring of MergeBoxWithClass processor modified
ee0ae90
@Manojkumarmuru
Returned array shape added in docstrings
223ce1d
@Manojkumarmuru
MergeBoxWithClass processor's docstring updated to convey more inform…
5d6c4fd 
…ation what is being done
@Manojkumarmuru
boxes renamed to box_data
a2390da
Manojkumarmuru and others added 17 commits May 23, 2023 14:30
@Manojkumarmuru
MergeBoxWithClass renamed to MergeNMSBoxWithClass
8b29fc1
@Manojkumarmuru
np.arange() used in place of range()
5744967
@Manojkumarmuru
Function get_score_from_class_label() added
b7dd1ef
@Manojkumarmuru
MergeBoxWithClass name updated for EfficientdetPostprocess
b5736ac
@Manojkumarmuru
Minor refactoring in merge_nms_box_with_class() function to minimize …
4d1dadc 
…value assignment to array
@Manojkumarmuru
Newly added functions/processors added to documentation
c2278f3
@Manojkumarmuru
Value assignment to array replaced with np.put() function which is co…
2df4b4c 
…mpatible with jax.numpy
@Manojkumarmuru
set_score_from_class_label() function added in documentation
9ee6a0d
@Manojkumarmuru
One approach for value assignment to an array using a mask array but …
6365860 
…still uses one for loop
@Manojkumarmuru
Array assignment without for loop
435f33f
@Manojkumarmuru
Unused function removed
78ff565
@Manojkumarmuru
Minor refactoring and variable renaming
56bac38
@Manojkumarmuru
Docstrings elaborated
4b19ce3
@Manojkumarmuru
Docstring elaborated
04df5fc
@Manojkumarmuru
Merge branch 'oarriaga:master' into master
9a999b5
@Manojkumarmuru
Merge branch 'master' of https://github.com/Manojkumarmuru/paz into e…
8383d5a 
…fficientdet
@Manojkumarmuru
Unit tests for nms_per_class() and merge_box_with_class() functions a…
ed08e23 
…dded
@oarriaga oarriaga merged commit 50d370c into oarriaga:master May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Manojkumarmuru @oarriaga