Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS Gems Move to https://github.com/aws/o3de-repo #2635

Merged
merged 3 commits into from
Jan 6, 2025
Merged

AWS Gems Move to https://github.com/aws/o3de-repo #2635

merged 3 commits into from
Jan 6, 2025

Conversation

AMZN-Gene
Copy link
Contributor

Change summary

Adding disclaimer to AWS gem setup to look for AWS gems under the new repo https://github.com/aws/o3de-repo
This document change works in correlation with this PR: o3de/o3de#18571

Submission Checklist:

  • [ x] Descriptive active voice - Do descriptive sentences have a clear subject and action verb?
  • [ x] Answer the question at hand - Does the documentation answer a what, why, how, or where type of question?
  • [ x] Consistency - Does the content consistently follow the Style Guide?
  • [ x] Help the user - Does the documentation show the user something meaningful?

@AMZN-Gene AMZN-Gene requested a review from a team as a code owner December 23, 2024 22:47
@AMZN-Gene AMZN-Gene mentioned this pull request Dec 30, 2024
Merged
ShaunaGordon
ShaunaGordon approved these changes Dec 31, 2024
View reviewed changes
Copy link
Contributor

@ShaunaGordon ShaunaGordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough to merge like this, but if you want to make it so you're not repeating yourself as much, this seems like a good candidate for a custom shortcode.

@AMZN-Gene
Adding shortcode for explaining that aws gems have moved repos
c011a80 
Signed-off-by: AMZN-Gene <genewalt@amazon.com>
@AMZN-Gene AMZN-Gene requested a review from a team as a code owner January 2, 2025 23:23
@AMZN-Gene
minor. adding better commenting to shortcode
283137b 
Signed-off-by: AMZN-Gene <genewalt@amazon.com>
@AMZN-Gene
Copy link
Contributor Author

Good enough to merge like this, but if you want to make it so you're not repeating yourself as much, this seems like a good candidate for a custom shortcode.

Thank you! Shortcode created. Let me know what you think :)

@AMZN-Gene AMZN-Gene requested a review from ShaunaGordon January 3, 2025 00:04
@AMZN-Gene AMZN-Gene merged commit a516367 into o3de:development Jan 6, 2025
5 checks passed
@AMZN-Gene AMZN-Gene deleted the MoveAWSGemsToAWSRepo branch January 6, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaunaGordon ShaunaGordon Awaiting requested review from ShaunaGordon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AMZN-Gene @ShaunaGordon