Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collects failed assets on LyTestTools test failures #7368

Merged
merged 10 commits into from
Feb 10, 2022

Conversation

evanchia-ly-sdets
Copy link
Contributor

Tested by running locally with failed assets. Unit tests pass.

Signed-off-by: evanchia evanchia@amazon.com

Signed-off-by: evanchia <evanchia@amazon.com>
@evanchia-ly-sdets evanchia-ly-sdets requested review from Kadino, AMZN-scspaldi and a team February 3, 2022 00:08
@evanchia-ly-sdets evanchia-ly-sdets added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Feb 3, 2022
Signed-off-by: evanchia <evanchia@amazon.com>
Copy link
Contributor

@Kadino Kadino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to check: this is for collecting logs of assets, not the assets themselves?

Tools/LyTestTools/ly_test_tools/o3de/editor_test_utils.py Outdated Show resolved Hide resolved
Tools/LyTestTools/ly_test_tools/o3de/editor_test_utils.py Outdated Show resolved Hide resolved
Signed-off-by: evanchia <evanchia@amazon.com>
@evanchia-ly-sdets
Copy link
Contributor Author

Just to check: this is for collecting logs of assets, not the assets themselves?

correct

Signed-off-by: evanchia <evanchia@amazon.com>
…llected

Signed-off-by: evanchia <evanchia@amazon.com>
Signed-off-by: evanchia <evanchia@amazon.com>
@Kadino Kadino added the do-not-merge/in-review Do not merge this PR. It is still being reviewed. label Feb 7, 2022
Signed-off-by: evanchia <evanchia@amazon.com>
Signed-off-by: evanchia <evanchia@amazon.com>
Signed-off-by: evanchia <evanchia@amazon.com>
Copy link
Contributor

@Kadino Kadino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feedback below are recommended changes which don't need to block moving forward with this PR.

Tools/LyTestTools/ly_test_tools/o3de/editor_test_utils.py Outdated Show resolved Hide resolved
Tools/LyTestTools/ly_test_tools/o3de/editor_test_utils.py Outdated Show resolved Hide resolved
Signed-off-by: evanchia <evanchia@amazon.com>
@Kadino Kadino merged commit 5ef2b12 into o3de:development Feb 10, 2022
@Kadino Kadino deleted the save_ap_artifacts branch February 10, 2022 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/in-review Do not merge this PR. It is still being reviewed. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants