Won't this break all 3rd party contributor / partner gems? We try to avoid doing this. (Is there a way to make the old macro still work?)

@Jackie9527 Can you post the script or command you used to perform the replacement?

Won't this break all 3rd party contributor / partner gems? We try to avoid doing this. (Is there a way to make the old macro still work?)

I don't see a change to the macro definition itself in Memory.h, so I think this is just changing all the engine uses of the macro, not the macro itself?

I hope all the folks shipping this did the same check as I did, but I checked out that repo, added an old style allocator (with the ,0) to it, ensured it still worked. Then I also did a

git diff dc444c414 | grep -v -i CLASS_ALLOCATOR | grep -i "+++"

to ensure that there were no other changes except for changes to class allocator lines.

Confirmed. Shipit.

I hope all the folks shipping this did the same check as I did, but I checked out that repo, added an old style allocator (with the ,0) to it, ensured it still worked. Then I also did a

git diff dc444c414 | grep -v -i CLASS_ALLOCATOR | grep -i "+++"

to ensure that there were no other changes except for changes to class allocator lines.

Confirmed. Shipit.

Very Unix-y! I like it

@Jackie9527 Can you post the script or command you used to perform the replacement?

I used VSCode to search, check and replace.
The key word is Allocator, 0), which is replaced to Allocator).

@Jackie9527 Can you post the script or command you used to perform the replacement?

I used VSCode to search, check and replace. The key word is Allocator, 0), which is replaced to Allocator).

Thanks for posting the command, I verified it the search only catches AZ_CLASS_ALLOCATOR lines using bash

$ find . \( -name "*.cpp" -o -name "*.h" -o -name "*.hxx" \) -exec grep -F "Allocator, 0)" {} \; > allocator.txt
$ awk '{ $1=$1; print }' < allocator.txt | sort > sorted.txt

It takes a while to run, but it outputs a sorted file of lines. The output only contains with lines related to AZ_CLASS_ALLOCATOR*, so this is change is good.

Here is a file that contains the list records found by searching for the string "Allocator, 0)" sorted.txt

Hi there, automated review failed with some error, see report here:
https://jenkins.build.o3de.org/blue/organizations/jenkins/O3DE/detail/PR-14530/3/pipeline/531

You may also need to pull latest to resolve the conflicts that have arisen since last week.
Let me know when this is fixed and I can start AR again :)

Hi there, automated review failed with some error, see report here: https://jenkins.build.o3de.org/blue/organizations/jenkins/O3DE/detail/PR-14530/3/pipeline/531

You may also need to pull latest to resolve the conflicts that have arisen since last week. Let me know when this is fixed and I can start AR again :)

done, the branch has been rebased using the latest commit [4f5259b].

Hi there, automated review failed with some error, see report here: https://jenkins.build.o3de.org/blue/organizations/jenkins/O3DE/detail/PR-14530/3/pipeline/531
You may also need to pull latest to resolve the conflicts that have arisen since last week. Let me know when this is fixed and I can start AR again :)

done, the branch has been rebased using the latest commit [4f5259b].

Another build is in progress at https://jenkins.build.o3de.org/job/O3DE/job/PR-14530/

Hi there, automated review failed with some error, see report here: https://jenkins.build.o3de.org/blue/organizations/jenkins/O3DE/detail/PR-14530/3/pipeline/531

You may also need to pull latest to resolve the conflicts that have arisen since last week. Let me know when this is fixed and I can start AR again :)

Good news is that most of the testcases are passed, only one is failed.
Bad news is that I don't know how to fix that, because I have run AzCore.Tests successfully on my machine.

Hi there, automated review failed with some error, see report here: https://jenkins.build.o3de.org/blue/organizations/jenkins/O3DE/detail/PR-14530/3/pipeline/531
You may also need to pull latest to resolve the conflicts that have arisen since last week. Let me know when this is fixed and I can start AR again :)

Good news is that most of the testcases are passed, only one is failed. Bad news is that I don't know how to fix that, because I have run AzCore.Tests successfully on my machine.

The failure that occurred in the AzCore.Tests was in the Parallel_Thread.Test, which is currently unstable and there is a github issue to address it (#14536).
I have re-kicked off another build and it should pass this time.