gem.json and project.json version updates #14112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Peterson <26804013+AMZN-alexpete@users.noreply.github.com>
Signed-off-by: Alex Peterson <26804013+AMZN-alexpete@users.noreply.github.com>
Signed-off-by: Alex Peterson <26804013+AMZN-alexpete@users.noreply.github.com>
AMZN-alexpete
requested review from
AMZN-Phil,
lemonade-dm and
tkothadev
and removed request for
a team
rgba16f
approved these changes
Jan 19, 2023
lemonade-dm
reviewed
Jan 19, 2023
lemonade-dm
reviewed
Jan 19, 2023
scripts/o3de/o3de/engine_template.py
Outdated
Comment on lines
2636
to
2637
| create_project_subparser.add_argument('-v', '--version', type=str, required=False, | ||
| help='An optional version. Defaults to 1.0.0') |
There was a problem hiding this comment.
If the default is 1.0.0, why isn't it set here?
There was a problem hiding this comment.
Also -v is normally using for a verbose option as it relates to logginc.
There was a problem hiding this comment.
It could be, I mostly tried to keep the defaults in the same location - which are currently in the create_project function.
Signed-off-by: Alex Peterson <26804013+AMZN-alexpete@users.noreply.github.com>
…oject-json-version-updates Signed-off-by: Alex Peterson <26804013+AMZN-alexpete@users.noreply.github.com> # Conflicts: # scripts/o3de/o3de/utils.py
lemonade-dm
approved these changes
Jan 19, 2023
cgalvan
approved these changes
Jan 19, 2023
Signed-off-by: Alex Peterson <26804013+AMZN-alexpete@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In an effort to secure world peace I present this finely crafted set of changes.
Though these changes may seem related to o3de/sig-core#44 they are in-fact designed to inspire a generation and bring about version 1.0.0 of ... something ... as they same in marines, "semverfy"
How was this PR tested?