Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed the loading of the legacy system_<platform>_<asset_platform>.cfg files #13721

Merged
merged 3 commits into from
Jan 10, 2023
Merged

Removed the loading of the legacy system_<platform>_<asset_platform>.cfg files #13721

merged 3 commits into from
Jan 10, 2023

Conversation

lemonade-dm
Copy link
Contributor

The settings registry has replaced the loading of platform specific setreg files using the Platform Abstraction Layer to determine platform specific folders.
This is detailed in the documentation
here

The settings registry can also issue console commands which is described on the Issue Console
Commands page

Signed-off-by: lumberyard-employee-dm 56135373+lumberyard-employee-dm@users.noreply.github.com

@lemonade-dm lemonade-dm requested review from a team as code owners December 15, 2022 20:11
amzn-phist
amzn-phist approved these changes Dec 15, 2022
View reviewed changes
Copy link
Contributor

@amzn-phist amzn-phist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question, are all the settings being deleted already set up somewhere in .setreg files? If not, do they need to be added?

@lemonade-dm lemonade-dm force-pushed the remove-legacy-system-cfg-files branch from 78cd066 to c966a9d Compare December 15, 2022 20:16
@lemonade-dm
Copy link
Contributor Author

lemonade-dm commented Dec 15, 2022 •
edited
Loading

Question, are all the settings being deleted already set up somewhere in .setreg files? If not, do they need to be added?

  • The log_includeTime CVAR would need it's default updated to 1
  • The sys_float_exceptions CVAR would need it's default updated to 0
  • The log_RemoteConsoleAllowedAddresses CVAR would need it's default updated to "127.0.0.1"
  • The sys_localization_format CVAR would need it's default updated to 0
  • The r_MaxWidth and r_MaxHeight CVAR doesn't exist
  • The r_ShadersAllowCompilation CVAR doesn't exist
  • The r_WidthAndHeightAsFractionOfScreenSize CVAR doesn't exist
  • The sys_affinity CVAR doesn't exist
  • The sys_physics_CPU CVAR doesn't exist
  • The r_fullscreen setting needs to be set to 1 on iOS and can be left as the default 0 for other platforms
  • The sys_PakLogInvalidFileAccess needs to be set to 1 for iOS and Android
  • The log_spamdelay CVAR is commented out.
  • The r_displayInfo is set to 3 for Linux, but it is fine to use 1 as the default
  • The r_width and r_height default to 1280x720 on Windows, Linux, MacOS, but the default values for them are 1920x1080

@KylerBessert
Copy link
Contributor

Question, do developers with an already created project have any additional work to do when this is merged? Should the developers switch these values on their previously created levels, or will the be updated automatically?

@lemonade-dm
Copy link
Contributor Author

Question, do developers with an already created project have any additional work to do when this is merged? Should the developers switch these values on their previously created levels, or will the be updated automatically?

I am adding settings registry files that invoke these console commands in the <engine-root>/Registry folder.

@lemonade-dm
Removed the loading of the legacy
bf51cae 
`system_<platform>_<asset_platform>.cfg` files

The settings registry has replaced the loading of platform specific
setreg files using the Platform Abstraction Layer to determine platform
specific folders.
This is detailed in the documentation
[here](https://www.o3de.org/docs/user-guide/settings/developer-documentation/#specialization-system-in-depth)

The settings registry can also issue console commands which is described
on the [Issue Console
Commands](https://www.o3de.org/docs/user-guide/settings/issue-az-console-commands/)
page

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
@lemonade-dm
Updated RemoteConsole, sys_localization_format and log_includeTime to…
55faa40 
… AZ CVars

Adding Settings Registry files for setting console variable values that
modify the windows layout to replicate the existing settings from the
old `system_<platform>_<asset_platform>.cfg` files

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
@lemonade-dm lemonade-dm force-pushed the remove-legacy-system-cfg-files branch from c966a9d to 55faa40 Compare January 7, 2023 01:37
@lemonade-dm lemonade-dm requested review from a team as code owners January 7, 2023 01:37
nick-l-o3de
nick-l-o3de approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@nick-l-o3de nick-l-o3de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Might save a little bit of startup time.

@lemonade-dm lemonade-dm requested a review from a team as a code owner January 9, 2023 19:25
Kadino
Kadino approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@Kadino Kadino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplifies LyTestTools, thanks!

@lemonade-dm lemonade-dm force-pushed the remove-legacy-system-cfg-files branch from aec52ae to 3a57189 Compare January 9, 2023 21:38
@lemonade-dm
Removed system_<platform>_<asset>.cfg uses from LyTestTools
04ab7e6 
The test tools were setting the `log_RemoteConsoleAllowedAddresses`
console variable, through those settings files and they have been
updated to specify those values through the command line arguments.
For Android test tools launcher, that console variable is set through
the Settings Registry
'/O3DE/Autoexec/ConsoleCommands/log_RemoteConsoleAllowedAddresses'
mechanism.

Also removed the validation of the `system_<platform>_<asset>.cfg` from
the CMake layout tool `verify_layout` method as it is no longer needed.

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
@lemonade-dm lemonade-dm force-pushed the remove-legacy-system-cfg-files branch from 3a57189 to 04ab7e6 Compare January 9, 2023 23:17
@lemonade-dm lemonade-dm merged commit c9bb592 into o3de:development Jan 10, 2023
@lemonade-dm lemonade-dm deleted the remove-legacy-system-cfg-files branch January 10, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evanchia-ly-sdets evanchia-ly-sdets evanchia-ly-sdets approved these changes

@nick-l-o3de nick-l-o3de nick-l-o3de approved these changes

@amzn-phist amzn-phist amzn-phist approved these changes

@cgalvan cgalvan cgalvan approved these changes

@Kadino Kadino Kadino approved these changes

@alexmontAmazon alexmontAmazon Awaiting requested review from alexmontAmazon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lemonade-dm @KylerBessert @Kadino @cgalvan @amzn-phist @nick-l-o3de @evanchia-ly-sdets