Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Go 1.13 support. Drop support of Go versions prior to 1.12 #15

Merged
merged 4 commits into from
Nov 5, 2019
Merged

Add Go 1.13 support. Drop support of Go versions prior to 1.12 #15

merged 4 commits into from
Nov 5, 2019

Conversation

o1egl
Copy link
Owner

@o1egl o1egl commented Nov 5, 2019 •
edited
Loading

  • Use new errors convention
  • Clean dependencies

@coveralls
Copy link

coveralls commented Nov 5, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 251

  • 33 of 62 (53.23%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.3%) to 87.666%
Changes Missing Coverage Covered Lines Changed/Added Lines %
utils.go 2 4 50.0%
parser.go 1 4 25.0%
v2.go 15 24 62.5%
v1.go 8 23 34.78%
Files with Coverage Reduction New Missed Lines %
parser.go 1 93.1%
Totals Coverage Status
Change from base Build 63: -0.3%
Covered Lines: 462
Relevant Lines: 527
💛 - Coveralls

@o1egl o1egl changed the title Add Go 1.13 support. Use new errors convention. Clean dependencies Add Go 1.13 support. Drop support of Go versions prior to 1.12 Nov 5, 2019
@o1egl o1egl merged commit 54e9d99 into master Nov 5, 2019
@o1egl o1egl deleted the go_1.13 branch November 10, 2019 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@o1egl @coveralls