Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deletedMessage field to MessageDeleteEvent #635

Merged
merged 4 commits into from
Mar 12, 2024
Merged

Add deletedMessage field to MessageDeleteEvent #635

merged 4 commits into from
Mar 12, 2024
+76 −24

Conversation

MCausc78
Copy link
Contributor

Description

<title>

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • Ran dart analyze or make analyze and fixed all issues
  • Ran dart format --set-exit-if-changed -l 160 ./lib or make format and fixed all issues
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Sorry, something went wrong.

abitofevrything
abitofevrything requested changes Mar 12, 2024
View reviewed changes
Copy link
Member

@abitofevrything abitofevrything left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check that all other delete events have a deletedXXX field (just as all update events have an oldXXX field)

@abitofevrything abitofevrything merged commit 1e8d5e5 into nyxx-discord:dev Mar 12, 2024
3 checks passed
@MCausc78 MCausc78 deleted the feat/deleted-message-in-messagedeleteevent branch March 12, 2024 15:30
@Lexedia Lexedia added the enhancement New feature or request label Mar 21, 2024
@Lexedia Lexedia added this to the 6.2.0 milestone Mar 21, 2024
abitofevrything pushed a commit that referenced this pull request Apr 1, 2024
@MCausc78 @abitofevrything
Add fields to delete events containing cached values before the delet…
ebd4503 
…ion (#635)

* add `deletedMessage` field to `MessageDeleteEvent`

* add `deletedMessages` field to `MessageBulkDeleteEvent` as well

* add `deletedX` field to thread/guild/guild member/role/integration delete events

* apply abito suggestion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abitofevrything abitofevrything

Assignees

@MCausc78 MCausc78

Labels
enhancement New feature or request
Projects
No open projects
nyxx roadmap
Status: Done
Milestone
6.2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MCausc78 @abitofevrything @Lexedia