Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more methods on models, bugfixes #628

Merged
merged 8 commits into from
Feb 17, 2024
Merged

Add more methods on models, bugfixes #628

merged 8 commits into from
Feb 17, 2024

Conversation

MCausc78
Copy link
Contributor

Description

  • Added more docs for manager methods
  • Added more methods on models
  • Added auditLogReason to StickerManager methods, and WebhookManager.update as well
  • Added includeId param in PermissionOverwriteBuilder.build() to make payloads more correct
  • Fix interactionsEndpointUrl being ignored in ApplicationUpdateBuilder
  • Fix auditLogReason in EmojiManager methods

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • Ran dart analyze or make analyze and fixed all issues
  • Ran dart format --set-exit-if-changed -l 160 ./lib or make format and fixed all issues
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

abitofevrything
abitofevrything requested changes Jan 23, 2024
View reviewed changes
Copy link
Member

@abitofevrything abitofevrything left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks generally OK, but we shouldn't be documenting things that are just overridden methods unless the behaviour changes significantly. I left a comment on the first few cases I came across, but there are more that should be fixed too.

lib/src/builders/application.dart Outdated Show resolved Hide resolved
lib/src/builders/guild/template.dart Outdated Show resolved Hide resolved
lib/src/http/managers/audit_log_manager.dart Outdated Show resolved Hide resolved
lib/src/http/managers/auto_moderation_manager.dart Outdated Show resolved Hide resolved
lib/src/http/managers/channel_manager.dart Outdated Show resolved Hide resolved
lib/src/http/managers/guild_manager.dart Outdated Show resolved Hide resolved
lib/src/http/managers/guild_manager.dart Outdated Show resolved Hide resolved
lib/src/http/managers/guild_manager.dart Outdated Show resolved Hide resolved
lib/src/http/managers/guild_manager.dart Outdated Show resolved Hide resolved
lib/src/http/managers/integration_manager.dart Outdated Show resolved Hide resolved
@l7ssha l7ssha added this to the 6.2.0 milestone Jan 23, 2024
@l7ssha l7ssha added the enhancement New feature or request label Jan 23, 2024
abitofevrything
abitofevrything requested changes Jan 25, 2024
View reviewed changes
lib/src/builders/application.dart Outdated Show resolved Hide resolved
lib/src/http/managers/application_manager.dart Outdated Show resolved Hide resolved
lib/src/http/managers/invite_manager.dart Outdated Show resolved Hide resolved
lib/src/http/managers/message_manager.dart Outdated Show resolved Hide resolved
lib/src/http/managers/message_manager.dart Outdated Show resolved Hide resolved
lib/src/http/managers/user_manager.dart Outdated Show resolved Hide resolved
lib/src/http/managers/webhook_manager.dart Outdated Show resolved Hide resolved
lib/src/http/managers/webhook_manager.dart Outdated Show resolved Hide resolved
lib/src/http/managers/webhook_manager.dart Outdated Show resolved Hide resolved
@abitofevrything
Copy link
Member

Still waiting on discord/discord-api-docs#6484, but looks good otherwise.

@MCausc78
Copy link
Contributor Author

image
OpenAPI spec says that interactions_endpoint_url/role_connections_verification_url can be nullable:

@abitofevrything abitofevrything merged commit 4ece7f7 into nyxx-discord:dev Feb 17, 2024
3 checks passed
@MCausc78 MCausc78 deleted the feat/more-methods-on-models branch February 17, 2024 14:34
@Lexedia Lexedia linked an issue Mar 22, 2024 that may be closed by this pull request
Allow to get more than 25 users who reacted on a message #629
Closed
abitofevrything pushed a commit that referenced this pull request Apr 1, 2024
@MCausc78 @abitofevrything
Add more methods on models, bugfixes (#628)
e351d54 
* cleanup

* improve

* for review

* changes that i forgor

* question mark

* fix #629 and `updateMfaLevel`

* fix tests

* ��
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lexedia Lexedia Lexedia left review comments

@abitofevrything abitofevrything abitofevrything approved these changes

@l7ssha l7ssha l7ssha approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
No open projects
nyxx roadmap
Status: Done
Milestone
6.2.0
Development

Successfully merging this pull request may close these issues.

Allow to get more than 25 users who reacted on a message
4 participants
@MCausc78 @abitofevrything @l7ssha @Lexedia