Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct serialization of request body in MessageManager.bulkDelete #618

Merged
merged 3 commits into from
Jan 6, 2024
Merged

Correct serialization of request body in MessageManager.bulkDelete #618

merged 3 commits into from
Jan 6, 2024

Conversation

abitofevrything
Copy link
Member

Description

As the title says.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Ran dart analyze or make analyze and fixed all issues
  • Ran dart format --set-exit-if-changed -l 160 ./lib or make format and fixed all issues
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@abitofevrything abitofevrything added the bug Something isn't working label Jan 6, 2024
@abitofevrything abitofevrything added this to the 6.2.0 milestone Jan 6, 2024
@abitofevrything abitofevrything self-assigned this Jan 6, 2024
@abitofevrything abitofevrything merged commit 797579b into dev Jan 6, 2024
7 checks passed
@abitofevrything abitofevrything deleted the bug/serialize-bulk-delete-messages branch January 6, 2024 17:08
abitofevrything added a commit that referenced this pull request Apr 1, 2024
@abitofevrything
Correct serialization of request body in MessageManager.bulkDelete (#618
3a9a058 
)

* Correct serialization of request body in MessageManager.bulkDelete

* Add auditLogReason parameter to MessageManager.bulkDelete

* Delete two messages in MessageManager.bulkDelete test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l7ssha l7ssha l7ssha approved these changes

Assignees

@abitofevrything abitofevrything

Labels
bug Something isn't working
Projects
No open projects
nyxx roadmap
Status: Done
Milestone
6.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@abitofevrything @l7ssha