Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export Credentials from package:oauth2 #604

Merged
merged 1 commit into from
Dec 9, 2023
Merged

Export Credentials from package:oauth2 #604

merged 1 commit into from
Dec 9, 2023

Conversation

abitofevrything
Copy link
Member

Description

We usually export types from other packages we use in our own API, but we didn't export Credentials. This PR adds that export.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Ran dart analyze or make analyze and fixed all issues
  • Ran dart format --set-exit-if-changed -l 160 ./lib or make format and fixed all issues
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@abitofevrything abitofevrything added the bug Something isn't working label Dec 9, 2023
@abitofevrything abitofevrything added this to the 6.1.0 milestone Dec 9, 2023
@abitofevrything abitofevrything self-assigned this Dec 9, 2023
@abitofevrything abitofevrything merged commit f23cfd2 into dev Dec 9, 2023
7 checks passed
@abitofevrything abitofevrything deleted the bug/export-oauth2-types branch December 9, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l7ssha l7ssha l7ssha approved these changes

Assignees

@abitofevrything abitofevrything

Labels
bug Something isn't working
Projects
No open projects
nyxx roadmap
Status: Done
Milestone
6.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@abitofevrything @l7ssha