Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invalid client voice state update, export NyxxPluginState #561

Merged
merged 2 commits into from
Sep 25, 2023
Merged

fix: invalid client voice state update, export NyxxPluginState #561

merged 2 commits into from
Sep 25, 2023

Conversation

priyanuj-gogoi
Copy link
Contributor

@priyanuj-gogoi priyanuj-gogoi commented Sep 25, 2023

Description

Fixes an issue where the client can't mute/deafen itself in a voice channel due to incorrect fields (mute & deaf) being sent.

The correct fields should be self_mute & self_deaf as shown in Discord docs.

Connected issues & other potential problems

2nd commit is related to #554

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Ran dart analyze or make analyze and fixed all issues
  • Ran dart format --set-exit-if-changed -l 160 ./lib or make format and fixed all issues
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@priyanuj-gogoi priyanuj-gogoi changed the title fix: incorrect voice state update for client fix: invalid client voice state update, export NyxxPluginState Sep 25, 2023
lib/src/builders/voice.dart Outdated Show resolved Hide resolved
@Lexedia Lexedia added bug Something isn't working enhancement New feature or request labels Sep 25, 2023
@Lexedia Lexedia added this to the 6.0 milestone Sep 25, 2023
@Lexedia Lexedia linked an issue Sep 25, 2023 that may be closed by this pull request
@Lexedia Lexedia removed the enhancement New feature or request label Sep 25, 2023
@abitofevrything abitofevrything merged commit c31514b into nyxx-discord:next Sep 25, 2023
@priyanuj-gogoi priyanuj-gogoi deleted the bug/gateway-voice-state-builder branch September 26, 2023 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

NyxxPluginState is not exported
4 participants