Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update member roles equality #438

Merged
merged 8 commits into from
Feb 12, 2023
Merged

Fix update member roles equality #438

merged 8 commits into from
Feb 12, 2023

Conversation

Lexedia
Copy link
Member

@Lexedia Lexedia commented Feb 2, 2023

Description

A comparison of list with == or != will always result false or true. Because lists are never the same in dart (except from constants with canonicalisation). This also fixes the nickname not updating.

Connected issues & other potential problems

-/-

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Ran dart analyze or make analyze and fixed all issues
  • Ran dart format --set-exit-if-changed -l 160 ./lib or make format and fixed all issues
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my changes haven't lowered code coverage

@Lexedia Lexedia added the bug Something isn't working label Feb 2, 2023
@Lexedia Lexedia added this to the 4.5 milestone Feb 2, 2023
@Lexedia Lexedia self-assigned this Feb 2, 2023
@l7ssha l7ssha merged commit 01f29c7 into dev Feb 12, 2023
@l7ssha l7ssha deleted the fix/list-member-equality branch February 12, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants