Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit bot start to plugins only when ready #392

Merged
merged 1 commit into from
Nov 13, 2022
Merged

Conversation

abitofevrything
Copy link
Member

Description

Changes the onBotStart plugin hook to act similar to the onReady event, to prevent plugins from accessing fields before they are initialised.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Ran dart analyze or make analyze and fixed all issues
  • Ran dart format --set-exit-if-changed -l 160 ./lib or make format and fixed all issues
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my changes haven't lowered code coverage

@abitofevrything abitofevrything added the bug Something isn't working label Nov 13, 2022
@abitofevrything abitofevrything added this to the 4.3.0 milestone Nov 13, 2022
@abitofevrything abitofevrything self-assigned this Nov 13, 2022
@abitofevrything abitofevrything merged commit 8b47436 into dev Nov 13, 2022
@abitofevrything abitofevrything deleted the bug/plugin-ready branch November 13, 2022 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants