Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement graceful shutdown #347

Merged
merged 1 commit into from
May 28, 2022
Merged

Implement graceful shutdown #347

merged 1 commit into from
May 28, 2022

Conversation

abitofevrything
Copy link
Member

Description

Allows nyxx clients to be disposed gracefully without throwing any errors. Also cleans up the disposing process, fixing resources that weren't disposed previously or weren't themselves disposed gradefully.

Type of change

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • Ran dart analyze or make analyze and fixed all issues
  • Ran dart format --set-exit-if-changed -l 160 ./lib or make format and fixed all issues
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my changes haven't lowered code coverage

@abitofevrything abitofevrything added the enhancement New feature or request label May 27, 2022
@abitofevrything abitofevrything added this to the 4.0 milestone May 27, 2022
@abitofevrything abitofevrything self-assigned this May 27, 2022
@l7ssha l7ssha merged commit 6444aae into next May 28, 2022
@l7ssha l7ssha deleted the feat/no-error-dispose branch May 28, 2022 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants