Fix an error occurring on message.save
#233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arunagw
changed the title
message.save.message.save
adarsh
approved these changes
Sep 3, 2019
| @@ -37,7 +37,7 @@ class Message | |||
| attribute :folder, :folder | |||
| attribute :folder_id, :string | |||
|
|
|||
| has_n_of_attribute :labels, :label | |||
| has_n_of_attribute :labels, :label, exclude_when: [:saving] | |||
There was a problem hiding this comment.
This is neat, although I can't tell where it is defined.
|
I don't think we need any documentation changes for this as excluding this is an internal change. We might remove this check when we implement change to allow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now when we call
.saveon a message it raises an errorbecause
labelsattributes also being sent to server along withother attributes. Server won't know anything about
labelsso itwas failing. This issues also mentioned here #183
This PR right now rejecting the
labelsattribute to be sent to server sowe can save a
message.In this PR also using a feature where we can define
exclude_whencallfor certain actions.