Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nylas/nylas-ruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.3.0
Choose a base ref
...
head repository: nylas/nylas-ruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.0.0
Choose a head ref
  • 19 commits
  • 20 files changed
  • 4 contributors

Commits on Dec 7, 2015

  1. Configuration menu
    Copy the full SHA
    abb7f90 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2015

  1. Remove get cursor as generate cursor is deprecated

    Summary: Removes get_cursor method and tests
    
    Test Plan:
    - run specs
    - run system tests
    
    Reviewers: khamidou
    
    Reviewed By: khamidou
    
    Subscribers: mg, spang
    
    Differential Revision: https://phab.nylas.com/D2360
    brettgerry committed Dec 18, 2015
    Configuration menu
    Copy the full SHA
    6d205f2 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2016

  1. Add reply_to field to Message class

    Dakota Nelson committed Jan 21, 2016
    Configuration menu
    Copy the full SHA
    31c4dde View commit details
    Browse the repository at this point in the history
  2. Allow limit and offset filters for collections

    The limit and offset filters, which were set correctly in the `where`
    function, were being overriden in the `get_model_collection` function
    by the offset and limit parameters passed to it (with defaults). The
    function now checks if limit or offset are already present in the list
    of filters before applying its own.
    
    Close issue #66.
    Dakota Nelson committed Jan 21, 2016
    Configuration menu
    Copy the full SHA
    9a54559 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #70 from nylas/add_reply_to

    Add reply_to field to Message class
    khamidou committed Jan 21, 2016
    Configuration menu
    Copy the full SHA
    4c7aeb2 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2016

  1. Refactor limit and offset to set in filters

    Previously, limit and offset could be specified in `@filters` (which
    were usually set inside a higher-level function such as `where` or
    `range`) and also as function parameters to the lower-level function
    `get_model_collection`. The decision as to whether or not the passed
    parameters would override those already present in `filters` was
    confusing and has been removed in favor of only using the `@filters`
    method.
    Dakota Nelson committed Jan 22, 2016
    Configuration menu
    Copy the full SHA
    ae7328b View commit details
    Browse the repository at this point in the history
  2. Add test for queries combining where and range

    Dakota Nelson committed Jan 22, 2016
    Configuration menu
    Copy the full SHA
    9b371a3 View commit details
    Browse the repository at this point in the history
  3. Remove vestigial comment

    Dakota Nelson committed Jan 22, 2016
    Configuration menu
    Copy the full SHA
    5dad1c4 View commit details
    Browse the repository at this point in the history
  4. Refactor delta_stream to allow multiple streams

    `delta_stream` is a blocking call, and previously had no good way to run
    in parallel in order to stream several accounts at once.
    
    EventMachine's run loop was removed from the library so that SDK
    implementers can create multiple streams inside their own EventMachine
    run block.
    
    `delta_stream` must be wrapped in an `EventMachine.run` block in order
    to function, whereas before it could be called plain. Two tests have
    been refactored to reflect this, and documentation has been updated.
    Dakota Nelson committed Jan 22, 2016
    Configuration menu
    Copy the full SHA
    dcd48bb View commit details
    Browse the repository at this point in the history
  5. Re-add HTTP error handling functionality

    Dakota Nelson committed Jan 22, 2016
    Configuration menu
    Copy the full SHA
    cce9e0a View commit details
    Browse the repository at this point in the history
  6. Update readme and changelog

    Dakota Nelson committed Jan 22, 2016
    Configuration menu
    Copy the full SHA
    3f5470b View commit details
    Browse the repository at this point in the history
  7. Cause each to respect offset and limit filters

    Also includes small optimization of the `while` function.
    Dakota Nelson committed Jan 22, 2016
    Configuration menu
    Copy the full SHA
    61b5587 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2016

  1. Merge pull request #73 from nylas/parallel-streams

    Refactor `delta_stream` to allow multiple streams
    khamidou committed Jan 29, 2016
    Configuration menu
    Copy the full SHA
    6023ad4 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2016

  1. Merge pull request #71 from nylas/limit-collections

    Allow limit and offset filters for collections
    khamidou committed Feb 4, 2016
    Configuration menu
    Copy the full SHA
    849c11e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    971bb00 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2016

  1. Configuration menu
    Copy the full SHA
    c6617d4 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2016

  1. fix system tests.

    khamidou committed Feb 6, 2016
    Configuration menu
    Copy the full SHA
    15d2bfd View commit details
    Browse the repository at this point in the history
  2. bump version

    khamidou committed Feb 6, 2016
    Configuration menu
    Copy the full SHA
    3259294 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    591df75 View commit details
    Browse the repository at this point in the history
Loading