Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] @nx-dotnet/core:serve produces invalid executing command #96

Closed
epic-media opened this issue Aug 26, 2021 · 4 comments · Fixed by #97
Closed

[BUG] @nx-dotnet/core:serve produces invalid executing command #96

epic-media opened this issue Aug 26, 2021 · 4 comments · Fixed by #97
Assignees
@AgentEnder
Labels
bug Something isn't working outdated scope: core

Comments

@epic-media
Copy link

Versions 1.3.0 and 1.3.1 produce the following executing command for @nx-dotnet/core:serve (which exits immediately with Exit Handler Called):

dotnet watch --project D:\path\to\project.csproj run --configuration Debug --runtime win-x64

When rolling back to 1.2.0 the correct command is generated and executes ok:

dotnet watch run --project D:\path\to\project.csproj --configuration Debug --runtime win-x64
@epic-media epic-media added bug Something isn't working needs-triage This issue has yet to be looked over by a core team member labels Aug 26, 2021
@AgentEnder AgentEnder self-assigned this Aug 26, 2021
@AgentEnder AgentEnder added scope: core and removed needs-triage This issue has yet to be looked over by a core team member labels Aug 26, 2021
@AgentEnder
Copy link
Member

Hey, I'll look into this sometime today. In 1.2 and earlier nx-dotnet used a custom filewatcher instead of dotnet watch, this was changed in 49ce6bc.

Does the test executor work fine for you?

AgentEnder added a commit that referenced this issue Aug 26, 2021
@AgentEnder
fix(core): serve + test --watch executor should not exit immediately
9ca8dee 
closes #96
@AgentEnder AgentEnder mentioned this issue Aug 26, 2021
Merged
@AgentEnder
Copy link
Member

Never mind, this was an easy fix. I abstracted the child_process logic out into a utility and didn't setup the promise correctly. This should be fixed in an hour or so after all the pipelines finish.

AgentEnder added a commit that referenced this issue Aug 26, 2021
@AgentEnder
fix(core): serve + test --watch executor should not exit immediately
8484202 
closes #96
github-actions bot pushed a commit that referenced this issue Aug 26, 2021
@semantic-release-bot
release: 1.3.2 [skip ci]
a71cbe8 
## [1.3.2](v1.3.1...v1.3.2) (2021-08-26)

### Bug Fixes

* **core:** serve + test --watch executor should not exit immediately ([8484202](8484202)), closes [#96](#96)

Aug 26, 2021, 3:31 PM
@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 1.3.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@AgentEnder AgentEnder

Labels
bug Something isn't working outdated scope: core
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(core): serve + test --watch executor should not exit immediately nx-dotnet/nx-dotnet
2 participants
@AgentEnder @epic-media