Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Question] dotnet watch #87

Closed
osnoser1 opened this issue Aug 21, 2021 · 3 comments · Fixed by #92
Closed

[Question] dotnet watch #87

osnoser1 opened this issue Aug 21, 2021 · 3 comments · Fixed by #92
Assignees
@AgentEnder
Labels
outdated

Comments

@osnoser1
Copy link

I've a question.

Why it doesn't use the dotnet watch run command to run the project instead of chokidar?

Using dotnet give the command the responsibility for refresh the project, and it could remove a dependency.
@AgentEnder
Copy link
Member

Honestly, the reasoning is just that I was unaware that dotnet watch run would refresh the projects when there was a change in the dependencies (i.e. if nx serve my-api was ran with dotnet watch run my-api.csproj, I thought that changing my-lib may not cause the serve to relaunch. I think I am mistaken in this though, I'll check and if I was wrong I'll get it swapped over.

@AgentEnder AgentEnder self-assigned this Aug 23, 2021
AgentEnder added a commit that referenced this issue Aug 23, 2021
@AgentEnder
feat(core): pickup global.json overrides at the project level
9007db3 
To accomplish this `dotnet` must be launched from the project's root directories.

Closes #87
Closes #86
@AgentEnder AgentEnder mentioned this issue Aug 23, 2021
Merged
AgentEnder added a commit that referenced this issue Aug 23, 2021
@AgentEnder
feat(core): pickup global.json overrides at the project level
7158090 
To accomplish this `dotnet` must be launched from the project's root directories.

Closes #87
Closes #86
AgentEnder added a commit that referenced this issue Aug 23, 2021
@AgentEnder
feat(core): pickup global.json overrides at the project level
8686bf2 
To accomplish this `dotnet` must be launched from the project's root directories.

Closes #87
Closes #86
AgentEnder added a commit that referenced this issue Aug 23, 2021
@AgentEnder
feat(core): pickup global.json overrides at the project level
43af793 
To accomplish this `dotnet` must be launched from the project's root directories.

Closes #87
Closes #86
AgentEnder added a commit that referenced this issue Aug 23, 2021
@AgentEnder
feat(core): pickup global.json overrides at the project level
17a05ba 
To accomplish this `dotnet` must be launched from the project's root directories.

Closes #87
Closes #86
AgentEnder added a commit that referenced this issue Aug 23, 2021
@AgentEnder
feat(core): pickup global.json overrides at the project level
29f96f2 
To accomplish this `dotnet` must be launched from the project's root directories.

Closes #87
Closes #86
github-actions bot pushed a commit that referenced this issue Aug 23, 2021
@semantic-release-bot
release: 1.3.0 [skip ci]
b9c1980 
# [1.3.0](v1.2.0...v1.3.0) (2021-08-23)

### Bug Fixes

* display project tag instead of [object Object] ([2dea7fc](2dea7fc))
* **core:** use fully qualified project name in msbuild task ([2c54310](2c54310))

### Features

* **core:** pickup `global.json` overrides at the project level ([49ce6bc](49ce6bc)), closes [#87](#87) [#86](#86)

Aug 23, 2021, 7:06 PM
@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 1.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@AgentEnder AgentEnder

Labels
outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(core): pick up global.json overrides from project level nx-dotnet/nx-dotnet
2 participants
@osnoser1 @AgentEnder