Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning "Project 'xxx' contains extension with invalid name (type)." #831

Merged
merged 1 commit into from
May 1, 2024

Conversation

edbzn
Copy link
Contributor

@edbzn edbzn commented Feb 21, 2024

Fixes the Nx warning Project 'xxx.xxx' contains extension with invalid name (type).

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@edbzn
Copy link
Contributor Author

edbzn commented Feb 26, 2024

@AgentEnder I'm pinging you in case you missed the notification

@AgentEnder
Copy link
Member

Hey @edbzn - I think this warning is actually because we are returning projects with type instead of projectType

@edbzn
Copy link
Contributor Author

edbzn commented Apr 29, 2024

Hey @AgentEnder, I updated the PR accordingly.

@edbzn edbzn changed the title fix(core): format project name without . Fix warning "Project 'xxx' contains extension with invalid name (type)." Apr 29, 2024
Copy link

nx-cloud bot commented Apr 29, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit d662c07. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
nx run-many --target=e2e --all --output-style=stream
✅ Successfully ran 5 targets

Sent with 💌 from NxCloud.

Fixes Nx warning `Project 'xxx' contains extension with invalid name (type).`
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@brnbs
Copy link

brnbs commented May 1, 2024

Can we have this released anytime soon? I just upgraded nx from 17.2.8 to 18.3.4 and nx-dotnet from 2.1.2 to 2.2.0 and got a bunch of these errors for all my dotnet projects:

Project 'ghos-browser-playwright-bridge' contains extension with invalid name (type).
Project 'ghos-browser-tests-webserver' contains extension with invalid name (type).
Project 'ghos-spoofing-engine-tests' contains extension with invalid name (type).
Project 'ghos-cli-infrastructure' contains extension with invalid name (type).
Project 'ghos-cli-application' contains extension with invalid name (type).
Project 'ghos-spoofing-engine' contains extension with invalid name (type).
Project 'ghos-browser-tests' contains extension with invalid name (type).
Project 'ghos-cli-domain' contains extension with invalid name (type).
Project 'ghos-cli-tests' contains extension with invalid name (type).
Project 'ghos-cli' contains extension with invalid name (type).

@AgentEnder AgentEnder merged commit 4c19278 into nx-dotnet:master May 1, 2024
6 of 7 checks passed
@AgentEnder
Copy link
Member

@edbzn don't worry about failing tests, they were unrelated to this PR. I need to spend some time getting this repo back into good shape 😅

Copy link
Contributor

github-actions bot commented May 7, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants