Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): do not use --verify-no-changes false for linting #802

Merged
merged 2 commits into from
Nov 29, 2023
Merged

fix(core): do not use --verify-no-changes false for linting #802

merged 2 commits into from
Nov 29, 2023

Conversation

kellyrbourg
Copy link
Contributor

These changes fix #797

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Nov 17, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit edb7e6b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 6 targets

Sent with 💌 from NxCloud.

@kellyrbourg
Copy link
Contributor Author

@AgentEnder any advice on how to fix the e2e test failure?

@AgentEnder AgentEnder merged commit 9026fcf into nx-dotnet:master Nov 29, 2023
7 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 29, 2023
@semantic-release-bot
release: 2.1.2 [skip ci]
b673b2f 
## [2.1.2](v2.1.1...v2.1.2) (2023-11-29)

### Bug Fixes

* **core:** do not use --verify-no-changes false for linting ([#802](#802)) ([9026fcf](9026fcf))

Nov 29, 2023, 4:01 PM
@github-actions GitHub Actions
Copy link
Contributor

🎉 This PR is included in version 2.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@zagros
Copy link

zagros commented Nov 29, 2023 •
edited
Loading

@kellyrbourg @AgentEnder

I still get the same issue:

image

and if I come to this file from your 2.1.2 release from 7 hours ago and manually delete the check to look like this it works

image

@zagros zagros mentioned this pull request Nov 29, 2023
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AgentEnder AgentEnder AgentEnder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Format boolean command line options don't work with false
3 participants
@kellyrbourg @zagros @AgentEnder