fix(core): options should be read correctly for project inference #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AgentEnder
force-pushed
the
fix/options-should-read-correctly-v17
branch
from
6737c2d to
9425cb1
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit b2693c0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
|
Thanks @AgentEnder this appears to resolve the CI issue we were seeing 👍 |
AgentEnder
force-pushed
the
fix/options-should-read-correctly-v17
branch
from
9425cb1 to
d5b87a1
Compare
AgentEnder
force-pushed
the
fix/options-should-read-correctly-v17
branch
from
d5b87a1 to
b2693c0
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
🎉 This PR is included in version 2.0.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's an issue with how we read configuration in Nx 17. It results in default values not being applied for some options, and project inference not working after migration.
This updates config handling to merge all values rather than relying on nullish handling.