fix(core): move generator not updating paths correctly #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit f5e4001. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ⌛ The following target is in progress ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
Tungsten78
force-pushed
the
fix-move-paths
branch
from
b012cef to
933601d
Compare
AgentEnder
requested changes
Oct 5, 2023
Tungsten78
force-pushed
the
fix-move-paths
branch
from
933601d to
0d5d565
Compare
|
Lgtm, can you take care of the sonar code smell? |
Tungsten78
force-pushed
the
fix-move-paths
branch
from
0d5d565 to
6aa50ea
Compare
Tungsten78
force-pushed
the
fix-move-paths
branch
from
6aa50ea to
f5e4001
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
AgentEnder
approved these changes
Oct 6, 2023
|
Awesome, thanks for the contribution 🎉 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
project.json paths weren't being updated correctly
Steps to reproduce
nx g @nx-dotnet/core:lib my-libnx g @nx-dotnet/core:move --projectName my-lib --destination a/b/cnx g @nx-dotnet/core:move --projectName a-b-c --destination my-libExpected result
sourceRoot,outputPaths, etc should be pathed correctlyActual result
Note: when this issue was discovered we noted
$schemawas also incorrect following the generator. This hasn't been reproducible but does show itself in the added unit test.