Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): make swagger tool run in project directory #758

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

EchelonFour
Copy link
Contributor

By moving the working directory of the swagger tool run the project directory, the generation can rely on external config files (like appsettings.json)

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@AgentEnder AgentEnder merged commit 12d89ac into nx-dotnet:master Sep 19, 2023
@AgentEnder
Copy link
Member

Hey @EchelonFour 🎉

Thanks for the contribution, sorry it took a while to get pulled in.

github-actions bot pushed a commit that referenced this pull request Sep 20, 2023
# [1.23.0](v1.22.0...v1.23.0) (2023-09-20)

### Bug Fixes

* **core:** add slash to use exact path ([#685](#685)) ([#687](#687)) ([1a87d83](1a87d83))
* **core:** codegen should not import self and default to required reference types ([#761](#761)) ([2310556](2310556))
* **core:** obey path in solution-file parameter when generating projects ([#762](#762)) ([29c234d](29c234d))
* **core:** support new name for enforce-module-boundaries eslint rule ([#742](#742)) ([24eb831](24eb831))
* **core:** update-swagger executor always reinstalls tool ([#757](#757)) ([63cf4b4](63cf4b4))
* **dotnet:** update args handling for dotnet format ([#678](#678)) ([772303e](772303e))

### Features

* **core:** add argument forwarding to dotnet new ([#722](#722)) ([cdc3654](cdc3654))
* **core:** make swagger tool run in project directory ([#758](#758)) ([12d89ac](12d89ac))

Sep 20, 2023, 3:59 PM
@github-actions
Copy link
Contributor

🎉 This PR is included in version 1.23.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants