feat(core): add argument forwarding to dotnet new #722
Conversation
☁️ Nx Cloud ReportAttention: This version of the Nx Cloud GitHub bot will cease to function on July 1st, 2023. An organization admin can update your integration here. CI is running/has finished running commands for commit e2930fd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 8 targets
Sent with 💌 from NxCloud. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
But yeah, anyways, I'd love to have your opinion on this @AgentEnder |
|
Kudos, SonarCloud Quality Gate passed!
|
|
@AgentEnder Have you had a chance to review this? |
There was a problem hiding this comment.
Hey @Soulusions 🎉
Sorry this has taken forever to get to, but it looks really good. I appreciate the e2e and unit tests that you've added, as they give the confidence that the syntax is working exactly how I'd like. I'll merge it now, and you can expect a new version out as soon as I get a few other things lined up (hopefully before next week).
For anyone else watching - the project is alive, but no changes have been required recently and while this is a valuable contribution its not been super necessary and I've put off merging new features in the meantime. The main reason for a new release at any point would be that compatibility with newer versions of Nx necessitated changes, or something pressing came up. I appreciate the users of the plugin though and am happy to have been able to spend some more time on this recently.
# [1.23.0](v1.22.0...v1.23.0) (2023-09-20) ### Bug Fixes * **core:** add slash to use exact path ([#685](#685)) ([#687](#687)) ([1a87d83](1a87d83)) * **core:** codegen should not import self and default to required reference types ([#761](#761)) ([2310556](2310556)) * **core:** obey path in solution-file parameter when generating projects ([#762](#762)) ([29c234d](29c234d)) * **core:** support new name for enforce-module-boundaries eslint rule ([#742](#742)) ([24eb831](24eb831)) * **core:** update-swagger executor always reinstalls tool ([#757](#757)) ([63cf4b4](63cf4b4)) * **dotnet:** update args handling for dotnet format ([#678](#678)) ([772303e](772303e)) ### Features * **core:** add argument forwarding to dotnet new ([#722](#722)) ([cdc3654](cdc3654)) * **core:** make swagger tool run in project directory ([#758](#758)) ([12d89ac](12d89ac)) Sep 20, 2023, 3:59 PM
|
🎉 This PR is included in version 1.23.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
@all-contributors add @Soulusions for code |
|
I've put up a pull request to add @Soulusions! 🎉 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
I've moved my version of this feature to its own PR.
This version is able to accept args passed after
--using the additionalProperties feature from JSON-Schema.Closes: #398
Closes: #262