Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generator option for standalone projects #71

Merged
merged 11 commits into from
Jul 12, 2021

Conversation

bcallaghan-et
Copy link
Collaborator

@bcallaghan-et bcallaghan-et commented Jul 8, 2021

Add a new option to the app, lib, and test generators to build standalone project.json files instead of placing all configuration in workspace.json. Update the local workspace to use the new standalone project configurations.

Resolves #70

Ben Callaghan added 4 commits July 8, 2021 12:00
Update nx to get access to the standalone project feature
Add a generator option for app, lib, and test to make standalone projects
Migrate all projects away from workspace.json for a cleaner workspace
Remove calls to the now-undefined global function
@nx-cloud
Copy link

nx-cloud bot commented Jul 8, 2021

Ben Callaghan added 2 commits July 9, 2021 15:34
Replace the Windows separator with a Unix separator for better interoperability.
Update syntax to the current version of jest to fix compile errors
@AgentEnder
Copy link
Member

AgentEnder commented Jul 9, 2021

@bcallaghan-et Looking into failing tests, this should help fix targets:

nx-ghpages:test

import * as fs from 'fs';

jest.mock('fs', () => ({
  ...(jest.requireActual('fs') as typeof fs),
  stat: (path: string, cb: (err: unknown, stats: unknown) => void) =>
    cb(null, {}),
}));

nxdoc-e2e:e2e
remove either async or the done parameter

core-e2e:e2e
add the following to nx.json under targetDependencies:

"e2e": [
      {
        "target": "build",
        "projects": "dependencies"
      }
]

I think this one should be fixed in 12.6, but quick enough fix for us 😄

Ben Callaghan added 3 commits July 9, 2021 17:39
Add actual fs module to avoid runtime errors in test
Remove done parameter to match jest's requirements
Add target dependency to ensure builds occur before e2e tests run
@bcallaghan-et
Copy link
Collaborator Author

@AgentEnder The e2e tests fail locally as well. Do you have any guidance why yarn would fail, or why @nx-dotnet/core/package.json can't be found?

@AgentEnder
Copy link
Member

Hey, yeah. Make sure to run the e2e with npm run e2e or yarn e2e instead of through Nx.

@bcallaghan-et
Copy link
Collaborator Author

I tried yarn e2e and that produced the same errors.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@AgentEnder AgentEnder merged commit 8db11d4 into nx-dotnet:master Jul 12, 2021
github-actions bot pushed a commit that referenced this pull request Jul 12, 2021
# [0.15.0](v0.14.0...v0.15.0) (2021-07-12)

### Features

* **core:** Add generator option for standalone projects ([#71](#71)) ([8db11d4](8db11d4))

Jul 12, 2021, 8:29 PM
@bcallaghan-et bcallaghan-et deleted the standalone-projects branch October 14, 2021 21:05
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add option for standalone projects
2 participants