fix(core): use for of on loop on project Map #661
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit cdcc828. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 7 targets
Sent with 💌 from NxCloud. |
|
Good news! this fix works. I'll patch up the unit test. |
|
Kudos, SonarCloud Quality Gate passed!
|
## [1.21.1](v1.21.0...v1.21.1) (2023-03-22) ### Bug Fixes * **core:** use for of on loop on project Map ([#661](#661)) ([c9d31d7](c9d31d7)) Mar 22, 2023, 11:13 PM
|
🎉 This PR is included in version 1.21.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Fixes #646
Turns out the loop was being skipped over. In JS
for inwill not iterate a Map. Switched to afor ofloop.NOTES:
Have a unit test but did not include it because fast glob is running against the file system so the unit test is rigged.
fast glob is supposed to support an
fsoption to use an alternative file system, however, I could not get this to work with tree. Adding a virtual file system was out of scope since this is a single line fix.