Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addresses #610 - fix(core): remove orphaned publish-local #611

Merged
merged 1 commit into from
Feb 3, 2023
Merged

Addresses #610 - fix(core): remove orphaned publish-local #611

merged 1 commit into from
Feb 3, 2023

Conversation

Tungsten78
Copy link
Contributor

@Tungsten78 Tungsten78 commented Feb 3, 2023 •
edited
Loading

  • add steps for using sandbox in CONTRIBUTING.MD

Fix #610

fix(core): remove orphaned publish-local
343825d 
- add steps for using sandbox in CONTRIBUTING.MD
@nx-cloud
Copy link

nx-cloud bot commented Feb 3, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 343825d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 9 targets

Sent with 💌 from NxCloud.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@AgentEnder AgentEnder merged commit 7985e14 into nx-dotnet:master Feb 3, 2023
@Tungsten78
Copy link
Contributor Author

Tungsten78 commented Feb 3, 2023 •
edited
Loading

@AgentEnder in retrospect, there's probably no reason to leave verdaccio and the sandbox script running - post creation the plugin is already installed.

Thoughts? EDIT: pertains to #614 comment about the script.

@AgentEnder
Copy link
Member

There are some reasons I like to keep the server running, and the script being active is a good indicator for that. The big thing is testing migrations, or testing on repos that aren't the sandbox itself.

github-actions bot pushed a commit that referenced this pull request Feb 4, 2023
@semantic-release-bot
release: 1.19.1 [skip ci]
6cf083b 
## [1.19.1](v1.19.0...v1.19.1) (2023-02-04)

### Bug Fixes

* **core:** adjust gitignore to support generation with directory ([#599](#599)) ([b3856e0](b3856e0))
* **core:** remove orphaned publish-local ([#611](#611)) ([7985e14](7985e14))

Feb 4, 2023, 7:17 PM
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2023

🎉 This PR is included in version 1.19.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

yarn publish-local broken. e2e-registry went missing from package.json
2 participants
@Tungsten78 @AgentEnder