Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove extra separator from project names #61

Merged
merged 2 commits into from
May 27, 2021
Merged

Remove extra separator from project names #61

merged 2 commits into from
May 27, 2021

Conversation

bcallaghan-et
Copy link
Collaborator

Remove the capturing parentheses from the split Regex to remove an extra dot from the name of the generated csproj file.

Fixes #60

Ben Callaghan added 2 commits May 27, 2021 13:38
fix(core): remove extra separator from project names
ceffcfd 
Remove capturing parentheses to keep separator out of the project's name

Fixes #60
test(core): reset options object before each test
3beed34 
Reset the options object to improve test isolation and repeatability
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nx-cloud
Copy link

nx-cloud bot commented May 27, 2021 •
edited
Loading

Nx Cloud Report

CI ran the following commands for commit 3beed34. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx affected --target=build --base=origin/master --parallel --with-deps
#000000 nx affected --target=lint --base=origin/master --parallel
#000000 nx affected --target=test --base=origin/master --parallel
#000000 nx run-many --all --target=build --with-deps
#000000 nx run-many --target=e2e --all

Sent with 💌 from NxCloud.

@AgentEnder AgentEnder merged commit 049367c into nx-dotnet:master May 27, 2021
@bcallaghan-et bcallaghan-et deleted the fix-project-separator branch May 27, 2021 21:34
github-actions bot pushed a commit that referenced this pull request May 27, 2021
@semantic-release-bot
release: 0.11.0 [skip ci]
a1604a7 
# [0.11.0](v0.10.3...v0.11.0) (2021-05-27)

### Bug Fixes

* **core:** Remove extra separator from project names ([#61](#61)) ([049367c](049367c)), closes [#60](#60)

### Features

* **docs-site:** support for docsearch ([#62](#62)) [skip ci] ([6d09f31](6d09f31))

May 27, 2021, 10:10 PM
@github-actions
Copy link
Contributor

🎉 This PR is included in version 0.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Extra dot is added when creating a library in a custom directory
2 participants
@bcallaghan-et @AgentEnder