Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Extra dot is added when creating a library in a custom directory #60

Closed
bcallaghan-et opened this issue May 27, 2021 · 2 comments · Fixed by #61
Closed

[BUG] Extra dot is added when creating a library in a custom directory #60

bcallaghan-et opened this issue May 27, 2021 · 2 comments · Fixed by #61
Labels
bug Something isn't working needs-triage This issue has yet to be looked over by a core team member outdated

Comments

@bcallaghan-et
Copy link
Collaborator

Describe the bug
When generating a new library with the --directory flag, an extra dot is added to the project's name. This also applies to the corresponding test project.

To Reproduce
Steps to reproduce the behavior:

  1. In a new Nx workspace, run the following command
nx generate @nx-dotnet/core:lib --name=my-lib --language=C# --template=classlib --testTemplate=xunit --directory=my-folder
  1. Open the newly generated folder libs/my-folder/my-lib.
  2. See that the name of the .csproj file is MyFolder..MyLib.csproj.

Expected behavior
The project's name should be MyFolder.MyLib.csproj with only one dot between the folder and project names.

Screenshots
The following screenshot shows a real-world example of this bug, using Nx Console to run the lib generator.
image

Environment:

  • OS: Windows
  • Browser: N/A
  • Version: 0.10.3
  • Affected Packages: @nx-dotnet/core
@bcallaghan-et bcallaghan-et added bug Something isn't working needs-triage This issue has yet to be looked over by a core team member labels May 27, 2021
bcallaghan-et referenced this issue in Etogy/nx-dotnet May 27, 2021
fix(core): remove extra separator from project names
ceffcfd 
Remove capturing parentheses to keep separator out of the project's name

Fixes #60
@bcallaghan-et bcallaghan-et mentioned this issue May 27, 2021
Merged
AgentEnder pushed a commit that referenced this issue May 27, 2021
@bcallaghan-et
fix(core): Remove extra separator from project names (#61)
049367c 
* fix(core): remove extra separator from project names

Remove capturing parentheses to keep separator out of the project's name

Fixes #60

* test(core): reset options object before each test

Reset the options object to improve test isolation and repeatability

Co-authored-by: Ben Callaghan <bcallaghan@selectbankcard.com>
github-actions bot pushed a commit that referenced this issue May 27, 2021
@semantic-release-bot
release: 0.11.0 [skip ci]
a1604a7 
# [0.11.0](v0.10.3...v0.11.0) (2021-05-27)

### Bug Fixes

* **core:** Remove extra separator from project names ([#61](#61)) ([049367c](049367c)), closes [#60](#60)

### Features

* **docs-site:** support for docsearch ([#62](#62)) [skip ci] ([6d09f31](6d09f31))

May 27, 2021, 10:10 PM
@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 0.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working needs-triage This issue has yet to be looked over by a core team member outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove extra separator from project names Etogy/nx-dotnet
1 participant
@bcallaghan-et