fix(core): getProjectFilesForProject should consider project root in addition to source root #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 3564803. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 9 targets
Sent with 💌 from NxCloud. |
AgentEnder
force-pushed
the
patch-1
branch
2 times, most recently
from
73bc00b to
51d9eb2
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
AgentEnder
changed the title
|
@all-contributors add kellyrbourg for code |
|
I've put up a pull request to add @kellyrbourg! 🎉 |
github-actions bot
pushed a commit
that referenced
this pull request
Oct 18, 2022
# [1.15.0](v1.14.0...v1.15.0) (2022-10-18) ### Bug Fixes * **core:** getProjectFilesForProject should consider project root in addition to source root ([#543](#543)) ([374e30f](374e30f)) ### Features * **nx-ghpages:** add option to customize commit message to `gh-pages` ([#542](#542)) ([cff00e0](cff00e0)) Oct 18, 2022, 9:12 PM
|
🎉 This PR is included in version 1.15.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can throw an error whenever you don't specify a source root.
Fixes issue: #465