Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): use strict proj glob pattern #495

Merged
merged 3 commits into from
Aug 19, 2022
Merged

fix(core): use strict proj glob pattern #495

merged 3 commits into from
Aug 19, 2022

Conversation

sukhanovr
Copy link
Contributor

Reused strict pattern from one of the executors and added some unit tests, used the same approach as fast-glob does in their project, using real testing files.

@nx-cloud
Copy link

nx-cloud bot commented Aug 18, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 6de2c5e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 9 targets

Sent with 💌 from NxCloud.

@sukhanovr sukhanovr mentioned this pull request Aug 18, 2022
Closed
@AgentEnder AgentEnder closed this Aug 18, 2022
@AgentEnder AgentEnder reopened this Aug 18, 2022
@AgentEnder
Copy link
Member

Can we move the fixtures folder down to the lib root? e.g. packages/utils/fixtures

@sukhanovr
Copy link
Contributor Author

Can we move the fixtures folder down to the lib root? e.g. packages/utils/fixtures

Absolutely! Done

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@AgentEnder AgentEnder merged commit 9720168 into nx-dotnet:master Aug 19, 2022
github-actions bot pushed a commit that referenced this pull request Aug 19, 2022
@semantic-release-bot
release: 1.13.1 [skip ci]
22b4159 
## [1.13.1](v1.13.0...v1.13.1) (2022-08-19)

### Bug Fixes

* **core:** @nrwl/js is required for library generation ([#484](#484)) ([13e2c93](13e2c93))
* **core:** use strict proj glob pattern ([#495](#495)) ([9720168](9720168))

Aug 19, 2022, 5:27 PM
@github-actions
Copy link
Contributor

🎉 This PR is included in version 1.13.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sukhanovr @AgentEnder