fix(core): test executor should fail properly #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit a36c891. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 5 targetsSent with 💌 from NxCloud. |
AgentEnder
force-pushed
the
fix/test-should-fail
branch
from
55349ec to
cc319d6
Compare
AgentEnder
force-pushed
the
fix/test-should-fail
branch
from
cc319d6 to
a36c891
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
github-actions bot
pushed a commit
that referenced
this pull request
Apr 13, 2022
## [1.9.10](v1.9.9...v1.9.10) (2022-04-13) ### Bug Fixes * **core:** fall back to root if source root null ([#408](#408)) ([53bdc17](53bdc17)) * **core:** resolved package version not provided ([#407](#407)) ([9bbc7c1](9bbc7c1)) * **core:** test executor should fail properly ([#411](#411)) ([e2db293](e2db293)) Apr 13, 2022, 9:06 PM
|
🎉 This PR is included in version 1.9.10 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving from
execSync->spawnSyncfor logAndExecute resulted in some executors returning invalid results. Notably,nx testwould return{success: true}despite thedotnet testcommand failing.