fix(core): resolved package version not provided #407
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 50f4069. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 5 targetsSent with 💌 from NxCloud. |
|
Kudos, SonarCloud Quality Gate passed!
|
| @@ -34,7 +34,7 @@ export default async function ( | |||
| resolvedVersion !== options.version && | |||
| resolvedVersion !== ALLOW_MISMATCH | |||
| ) { | |||
| options.version = resolvedVersion; | |||
| params.version = resolvedVersion; | |||
There was a problem hiding this comment.
On line 20, do you care to add allowVersionMismatch to the destructure? It shouldn't be passed to dotnet.
Thats a leftover issue from my impl, and otherwise this looks good. thanks!
AgentEnder
changed the title
|
@allcontributors add @dasco144 for code |
|
I've put up a pull request to add @dasco144! 🎉 |
## [1.9.10](v1.9.9...v1.9.10) (2022-04-13) ### Bug Fixes * **core:** fall back to root if source root null ([#408](#408)) ([53bdc17](53bdc17)) * **core:** resolved package version not provided ([#407](#407)) ([9bbc7c1](9bbc7c1)) * **core:** test executor should fail properly ([#411](#411)) ([e2db293](e2db293)) Apr 13, 2022, 9:06 PM
|
🎉 This PR is included in version 1.9.10 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Fixes an issue I came across while running the nuget reference generator.
Basically, the resolved version is not passed to addPackageReference on line 41.