-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): add executor for dotnet publish #33 #36
Conversation
Add a publish command for a future publish executor to use
Add a publish executor that delegates to `dotnet publish` Resolves #33
Add support for commonly used but unusually formatted MSBuild properties.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are a few gut-check comments, will check some of the functionality out tomorrow morning and then we can get this merged in.
Fix the name of the executor to be consistent with real world targets.
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
# [0.5.0-dev.1](v0.4.1...v0.5.0-dev.1) (2021-05-06) ### Bug Fixes * **core:** [#34](#34) remove spec files from built plugin ([f075046](f075046)) * **core:** [#35](#35) dry run is not passed to dotnet new ([8e0b398](8e0b398)) ### Features * **core:** add executor for dotnet publish [#33](#33) ([#36](#36)) ([f7cbd27](f7cbd27))
🎉 This PR is included in version 0.5.0-dev.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
* feat(dotnet): add publish command to client Add a publish command for a future publish executor to use * feat(core): add publish executor Add a publish executor that delegates to `dotnet publish` Resolves #33 * feat(core): add MSBuild properties to publish executor Add support for commonly used but unusually formatted MSBuild properties. * test(core): fix name of publish executor in tests Fix the name of the executor to be consistent with real world targets. Co-authored-by: Ben Callaghan <bcallaghan@selectbankcard.com>
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
No description provided.