Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add executor for dotnet publish #33 #36

Merged
merged 5 commits into from
May 6, 2021

Conversation

bcallaghan-et
Copy link
Collaborator

No description provided.

Ben Callaghan added 4 commits May 4, 2021 13:01
Add a publish command for a future publish executor to use
Add a publish executor that delegates to `dotnet publish`

Resolves #33
Add support for commonly used but unusually formatted MSBuild properties.
Copy link
Member

@AgentEnder AgentEnder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are a few gut-check comments, will check some of the functionality out tomorrow morning and then we can get this merged in.

Fix the name of the executor to be consistent with real world targets.
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 5, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@AgentEnder AgentEnder merged commit f7cbd27 into nx-dotnet:dev May 6, 2021
github-actions bot pushed a commit that referenced this pull request May 6, 2021
# [0.5.0-dev.1](v0.4.1...v0.5.0-dev.1) (2021-05-06)

### Bug Fixes

* **core:** [#34](#34) remove spec files from built plugin ([f075046](f075046))
* **core:** [#35](#35) dry run is not passed to dotnet new ([8e0b398](8e0b398))

### Features

* **core:** add executor for dotnet publish [#33](#33) ([#36](#36)) ([f7cbd27](f7cbd27))
@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2021

🎉 This PR is included in version 0.5.0-dev.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

AgentEnder pushed a commit that referenced this pull request May 6, 2021
* feat(dotnet): add publish command to client

Add a publish command for a future publish executor to use

* feat(core): add publish executor

Add a publish executor that delegates to `dotnet publish`

Resolves #33

* feat(core): add MSBuild properties to publish executor

Add support for commonly used but unusually formatted MSBuild properties.

* test(core): fix name of publish executor in tests

Fix the name of the executor to be consistent with real world targets.

Co-authored-by: Ben Callaghan <bcallaghan@selectbankcard.com>
github-actions bot pushed a commit that referenced this pull request May 6, 2021
# [0.5.0-dev.1](v0.4.2...v0.5.0-dev.1) (2021-05-06)

### Features

* **core:** add executor for dotnet publish [#33](#33) ([#36](#36)) ([ac8c898](ac8c898))
github-actions bot pushed a commit that referenced this pull request May 6, 2021
# [0.5.0](v0.4.2...v0.5.0) (2021-05-06)

### Features

* **core:** add executor for dotnet publish [#33](#33) ([#36](#36)) ([ac8c898](ac8c898))
@bcallaghan-et bcallaghan-et deleted the dotnet-publish branch May 6, 2021 15:56
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants