Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): support for workspace solution files #254

Merged
merged 3 commits into from
Nov 29, 2021
Merged

feat(core): support for workspace solution files #254

merged 3 commits into from
Nov 29, 2021

Conversation

AgentEnder
Copy link
Member

@AgentEnder AgentEnder commented Nov 27, 2021 •
edited
Loading

Supports passing --solution {path}, or --solution to add a project to a specific or default solution file in the workspace. To use this behavior for all projects in the workspace, add a section to nx.json like

{
  //...
  generators: {
    //...
    "@nx-dotnet/core:app": {
      "solutionFile": true // or "MySolutionFile.sln" etc
    }
  }
}

Closes #241

@nx-cloud
Copy link

nx-cloud bot commented Nov 27, 2021 •
edited
Loading

Nx Cloud Report

CI ran the following commands for commit 650c21d. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --all --target=build
#000000 nx run-many --target=e2e --all
#000000 nx run-many --all --target=build
#000000 nx affected --target=build --base=origin/master --parallel
#000000 nx affected --target=lint --base=origin/master --parallel
#000000 nx affected --target=test --base=origin/master --parallel
#000000 nx affected --target=build --base=origin/master --parallel
#000000 nx affected --target=test --base=origin/master --parallel
#000000 nx affected --target=lint --base=origin/master --parallel

Sent with 💌 from NxCloud.

@AgentEnder AgentEnder marked this pull request as ready for review November 27, 2021 22:18
@benjcallaghan
Copy link

LGTM. I especially like the e2e tests, which helped me understand what it was doing better than the documentation did.

@AgentEnder
docs(core): add docs for solution handling
650c21d 
chore(repo): update e2e script and add sandbox command
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@AgentEnder AgentEnder merged commit ec342ae into master Nov 29, 2021
@AgentEnder AgentEnder deleted the feat/workspace-sln branch November 29, 2021 15:01
github-actions bot pushed a commit that referenced this pull request Nov 29, 2021
@semantic-release-bot
release: 1.7.0 [skip ci]
8fdc479 
# [1.7.0](v1.6.0...v1.7.0) (2021-11-29)

### Features

* **core:** support for workspace solution files ([#254](#254)) ([ec342ae](ec342ae))

Nov 29, 2021, 3:07 PM
@github-actions
Copy link
Contributor

🎉 This PR is included in version 1.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@benjcallaghan benjcallaghan benjcallaghan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Add support for .NET solution files when generating new projects
2 participants
@AgentEnder @benjcallaghan