Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): support nx v13 #226

Merged
merged 3 commits into from
Oct 22, 2021
Merged

feat(core): support nx v13 #226

merged 3 commits into from
Oct 22, 2021

Conversation

benpsnyder
Copy link
Contributor

nx migrate latest

@nx-cloud
Copy link

nx-cloud bot commented Oct 21, 2021 •
edited
Loading

Nx Cloud Report

CI ran the following commands for commit 4b201a4. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=e2e --all
#000000 nx run-many --all --target=build
#000000 nx affected --target=test --base=origin/master --parallel
#000000 nx affected --target=lint --base=origin/master --parallel
#000000 nx affected --target=build --base=origin/master --parallel

Sent with 💌 from NxCloud.

AgentEnder
AgentEnder requested changes Oct 21, 2021
View reviewed changes
Copy link
Member

@AgentEnder AgentEnder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the few deps back that got downgraded please 😄

Otherwise, looks good to me. This update doesn't affect the .NET side at all and the nx changes are minimal.

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@pemsbr
Copy link
Contributor

pemsbr commented Oct 22, 2021

Both the nx.json and workspace.json schemas changed

@AgentEnder
Copy link
Member

Yeah, ill probably add a commit onto this branch to update that portion. There's some ways to do it that won't break compat with 12.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@AgentEnder AgentEnder changed the title chore(deps): upgrade to Nx 13.0.x feat(core): support nx v13 Oct 22, 2021
@AgentEnder AgentEnder merged commit 3524ef9 into nx-dotnet:master Oct 22, 2021
github-actions bot pushed a commit that referenced this pull request Oct 22, 2021
@semantic-release-bot
release: 1.6.0 [skip ci]
e9da79b 
# [1.6.0](v1.5.2...v1.6.0) (2021-10-22)

### Features

* **core:** support nx v13 ([#226](#226)) ([3524ef9](3524ef9))

Oct 22, 2021, 3:16 PM
@github-actions
Copy link
Contributor

🎉 This PR is included in version 1.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AgentEnder AgentEnder AgentEnder requested changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benpsnyder @pemsbr @AgentEnder