-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): check for .net sdk install on package add #212
Conversation
Nx Cloud ReportCI ran the following commands for commit e51e81e. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch Sent with 💌 from NxCloud. |
f33b5ac
to
f8a6f90
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
f8a6f90
to
e51e81e
Compare
# [1.5.0](v1.4.3...v1.5.0) (2021-10-15) ### Features * **core:** @nx-dotnet/core:serve can be ran with --watch false ([#210](#210)) ([9fd60e4](9fd60e4)), closes [#151](#151) * **core:** check for .net sdk install on package add ([#212](#212)) ([2ec5de9](2ec5de9)) * **core:** project references with reference output assembly=false are implicit deps ([#211](#211)) ([34f87ee](34f87ee)) Oct 15, 2021, 6:21 AM
Hey @AgentEnder I think this breaks restore. After clearing my node modules and installing using PNPM I get this:
I think it's because no dependencies are specified and @nx-dotnet is being installed before @nrwl/tao Otherwise because of the way PNPM works the @nrwl/tao folder just doesn't exist yet. |
Yep this fixed it, so need to add a dependency to the package to ensure this script works
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Closes #3