Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): check for .net sdk install on package add #212

Merged
merged 1 commit into from
Oct 15, 2021

Conversation

AgentEnder
Copy link
Member

Closes #3

@nx-cloud
Copy link

nx-cloud bot commented Oct 15, 2021

@AgentEnder AgentEnder changed the base branch from master to 1.5 October 15, 2021 05:20
@AgentEnder AgentEnder force-pushed the feat/check-for-dotnet-on-install branch from f33b5ac to f8a6f90 Compare October 15, 2021 05:35
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@AgentEnder AgentEnder force-pushed the feat/check-for-dotnet-on-install branch from f8a6f90 to e51e81e Compare October 15, 2021 06:00
@AgentEnder AgentEnder merged commit 6ef3a3c into 1.5 Oct 15, 2021
@AgentEnder AgentEnder deleted the feat/check-for-dotnet-on-install branch October 15, 2021 06:08
github-actions bot pushed a commit that referenced this pull request Oct 15, 2021
# [1.5.0](v1.4.3...v1.5.0) (2021-10-15)

### Features

* **core:** @nx-dotnet/core:serve can be ran with --watch false ([#210](#210)) ([9fd60e4](9fd60e4)), closes [#151](#151)
* **core:** check for .net sdk install on package add ([#212](#212)) ([2ec5de9](2ec5de9))
* **core:** project references with reference output assembly=false are implicit deps ([#211](#211)) ([34f87ee](34f87ee))

Oct 15, 2021, 6:21 AM
@JakeGinnivan
Copy link

Hey @AgentEnder I think this breaks restore.

After clearing my node modules and installing using PNPM I get this:

.../node_modules/@nx-dotnet/core postinstall$ node ./src/tasks/post-install
│ node:internal/modules/cjs/loader:936
│   throw err;
│   ^
│ Error: Cannot find module '@nrwl/tao/src/utils/app-root

I think it's because no dependencies are specified and @nx-dotnet is being installed before @nrwl/tao

Otherwise because of the way PNPM works the @nrwl/tao folder just doesn't exist yet.

@JakeGinnivan
Copy link

JakeGinnivan commented Nov 10, 2021

Yep this fixed it, so need to add a dependency to the package to ensure this script works

  "pnpm": {
    "packageExtensions": {
      "@nx-dotnet": {
        "dependencies": {
          "@nrwl/tao": ">13"
        }
      }
    }
  }

@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check if .NET SDK is installed on plugin add
2 participants