Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): Support for nx test my-dotnet-app #20

Closed
AgentEnder opened this issue Apr 20, 2021 · 3 comments
Closed

feat(core): Support for nx test my-dotnet-app #20

AgentEnder opened this issue Apr 20, 2021 · 3 comments
Assignees
@AgentEnder
Labels
enhancement New feature or request minimum-viable-product outdated
Milestone
Initial Release

Comments

@AgentEnder
Copy link
Member

No description provided.

AgentEnder added a commit that referenced this issue Apr 20, 2021
@AgentEnder
feat(core): generate test projects #20
086625f 
chore(repo): enable TS strict + fix errors
AgentEnder added a commit that referenced this issue Apr 20, 2021
@AgentEnder
feat(core): #20 add support for test projects to library generator
9ee7fa9
@AgentEnder AgentEnder added this to the Initial Release milestone Apr 20, 2021
@bcallaghan-et
Copy link
Collaborator

The option for test-template cannot be specified on the command line. When parsing the command-line arguments, the flag --test-template will be converted to the key testTemplate on the options object. The generator then checks options['test-template'], which will never contain a value. Consider the command npx nx generate @nx-dotnet/core:app my-app --template console --language C# --test-template none. The prompt asking which test template should be used is shown, even though the test template was specified in the arguments. The field used in the code and in the schema should be changed to testTemplate so the parsed value is correctly interpreted.

@AgentEnder AgentEnder self-assigned this Apr 27, 2021
@AgentEnder
Copy link
Member Author

Nice catch, I was not aware the argument would be transformed like that, though it does make sense. I'll get that updated tomorrow morning (hope to have the test executor then as well.)

AgentEnder added a commit that referenced this issue Apr 28, 2021
@AgentEnder
fix(core): #20 test template arg cannot be passed from command line
f74900a
github-actions bot pushed a commit that referenced this issue Apr 28, 2021
@semantic-release-bot
release(): 0.3.0-dev.1 [skip ci]
b76fb16 
# [0.3.0-dev.1](v0.2.1-dev.1...v0.3.0-dev.1) (2021-04-28)

### Bug Fixes

* **core:** [#20](#20) test template arg cannot be passed from command line ([f74900a](f74900a))
* **repo:** semantic-release not updating package.json ([de9fcd9](de9fcd9))

### Features

* **core:** dotnet test support ([adbb532](adbb532))
AgentEnder added a commit that referenced this issue Apr 28, 2021
@AgentEnder
feat(core): dotnet test support #20
02ceed0
AgentEnder added a commit that referenced this issue Apr 28, 2021
@AgentEnder
fix(core): #20 test template arg cannot be passed from command line
e9e47e0
github-actions bot pushed a commit that referenced this issue Apr 28, 2021
@semantic-release-bot
release(): 0.3.0-dev.3 [skip ci]
5fe6f90 
# [0.3.0-dev.3](v0.3.0-dev.2...v0.3.0-dev.3) (2021-04-28)

### Bug Fixes

* **core:** [#20](#20) test template arg cannot be passed from command line ([e9e47e0](e9e47e0))
* **repo:** semantic-release not updating package.json ([9273001](9273001))

### Features

* **core:** dotnet test support [#20](#20) ([02ceed0](02ceed0))
github-actions bot pushed a commit that referenced this issue Apr 28, 2021
@semantic-release-bot
release(): 0.3.0 [skip ci]
0f9fda7 
# [0.3.0](v0.2.1...v0.3.0) (2021-04-28)

### Bug Fixes

* **core:** [#20](#20) test template arg cannot be passed from command line ([e9e47e0](e9e47e0))
* **repo:** semantic-release not updating package.json ([9273001](9273001))

### Features

* **core:** dotnet test support [#20](#20) ([02ceed0](02ceed0))
@github-actions
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@AgentEnder AgentEnder

Labels
enhancement New feature or request minimum-viable-product outdated
Projects
None yet
Milestone
Initial Release
Development

No branches or pull requests
2 participants
@AgentEnder @bcallaghan-et