feat(core): test sr deployment

nx-dotnet · Apr 26, 2021 · fbc5bbf · fbc5bbf
1 parent a44f26f
commit fbc5bbf
Show file tree

Hide file tree

Showing 6 changed files with 16 additions and 9 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -79,12 +79,6 @@ jobs:
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
-      - name: Push changes
-        uses: ad-m/github-push-action@master
-        with:
-          github_token: ${{ secrets.GITHUB_TOKEN }}
-          branch: ${{ github.ref }}
-          tags: true
 
   # e2e:
   #   runs-on: ubuntu-latest

diff --git a/packages/core/src/generators/init/schema.json b/packages/core/src/generators/init/schema.json
@@ -1,8 +1,9 @@
 {
   "$schema": "http://json-schema.org/schema",
   "cli": "nx",
-  "id": "Init",
-  "title": "",
+  "id": "@nx-dotnet/core:init",
+  "title": "Initialize NxDotnet",
+  "description": "Update's user's gitignore file + initializes a blank config",
   "type": "object",
   "properties": {},
   "required": []

diff --git a/packages/core/src/models/build-executor-configuration.ts b/packages/core/src/models/build-executor-configuration.ts
@@ -1,5 +1,8 @@
 import { TargetConfiguration } from '@nrwl/devkit';
 
+/**
+ * Returns a TargetConfiguration for the nx-dotnet/core:build executor
+ */
 export function GetBuildExecutorConfiguration(
   projectName: string
 ): BuildExecutorConfiguration {
@@ -20,6 +23,9 @@ export function GetBuildExecutorConfiguration(
   };
 }
 
+/**
+ * Configuration options relevant for the build executor
+ */
 export interface BuildExecutorConfiguration extends TargetConfiguration {
   options: {
     output: string;

diff --git a/packages/core/src/models/project-generator-schema.ts b/packages/core/src/models/project-generator-schema.ts
@@ -1,3 +1,6 @@
+/**
+ * Typing for the shared project generator's options
+ */
 export interface NxDotnetProjectGeneratorSchema {
   name: string;
   tags?: string;

diff --git a/packages/core/src/models/serve-executor-configuration.ts b/packages/core/src/models/serve-executor-configuration.ts
@@ -14,6 +14,9 @@ export function GetServeExecutorConfig(): ServeTargetConfiguration {
   };
 }
 
+/**
+ * Target configuration for nx-dotnet/core:serve
+ */
 export interface ServeTargetConfiguration extends TargetConfiguration {
   options: {
     configuration: 'Debug' | 'Release';

diff --git a/tsconfig.base.json b/tsconfig.base.json
@@ -10,7 +10,7 @@
     "importHelpers": true,
     "target": "es2015",
     "module": "esnext",
-    "lib": ["es2017", "dom"],
+    "lib": ["es2019", "dom"],
     "skipLibCheck": true,
     "skipDefaultLibCheck": true,
     "baseUrl": ".",