feat(core): add lint config to generated projects

Add lint configuration to all new projects for user convenience.
nx-dotnet · May 19, 2021 · d320ce8 · d320ce8
1 parent 92afd05
commit d320ce8
Show file tree

Hide file tree

Showing 4 changed files with 24 additions and 0 deletions.
diff --git a/packages/core/src/generators/utils/generate-project.spec.ts b/packages/core/src/generators/utils/generate-project.spec.ts
@@ -94,6 +94,19 @@ describe('nx-dotnet project generator', () => {
     expect(config.targets.serve).toBeDefined();
   });
 
+  it('should include lint target', async () => {
+    await GenerateProject(appTree, options, dotnetClient, 'application');
+    const config = readProjectConfiguration(appTree, 'test');
+    expect(config.targets.lint).toBeDefined();
+  });
+
+  it('should include lint target in test project', async () => {
+    options.testTemplate = 'nunit';
+    await GenerateProject(appTree, options, dotnetClient, 'application');
+    const config = readProjectConfiguration(appTree, 'test-test');
+    expect(config.targets.lint).toBeDefined();
+  });
+
   /**
    * This test requires a live dotnet client.
    */

diff --git a/packages/core/src/generators/utils/generate-project.ts b/packages/core/src/generators/utils/generate-project.ts
@@ -23,6 +23,7 @@ import {
 
 import {
   GetBuildExecutorConfiguration,
+  GetLintExecutorConfiguration,
   GetServeExecutorConfig,
   GetTestExecutorConfig,
   NxDotnetProjectGeneratorSchema,
@@ -97,6 +98,7 @@ async function GenerateTestProject(
     targets: {
       build: GetBuildExecutorConfiguration(testRoot),
       test: GetTestExecutorConfig(),
+      lint: GetLintExecutorConfiguration(),
     },
     tags: schema.parsedTags,
   });
@@ -192,6 +194,7 @@ export async function GenerateProject(
       ...(projectType === 'application'
         ? { serve: GetServeExecutorConfig() }
         : {}),
+      lint: GetLintExecutorConfiguration(),
     },
     tags: normalizedOptions.parsedTags,
   };

diff --git a/packages/core/src/models/index.ts b/packages/core/src/models/index.ts
@@ -2,3 +2,4 @@ export * from './build-executor-configuration';
 export * from './project-generator-schema';
 export * from './serve-executor-configuration';
 export * from './test-executor-configuration';
+export * from './lint-executor-configuration';
diff --git a/packages/core/src/models/lint-executor-configuration.ts b/packages/core/src/models/lint-executor-configuration.ts
@@ -0,0 +1,7 @@
+import { TargetConfiguration } from '@nrwl/devkit';
+
+export function GetLintExecutorConfiguration(): TargetConfiguration {
+  return {
+    executor: '@nx-dotnet/core:format',
+  };
+}