fix(core): sync command should list package names (#41)

fixes #39
nx-dotnet · May 6, 2021 · 8bdc66a · 8bdc66a
1 parent 5f2d5c9
commit 8bdc66a
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 3 deletions.
diff --git a/packages/core/src/generators/nuget-reference/generator.ts b/packages/core/src/generators/nuget-reference/generator.ts
@@ -30,6 +30,7 @@ export default async function (
     options.version,
     configuredPkgVersion,
     options.allowVersionMismatch,
+    options.packageName,
   );
   config.nugetPackages[options.packageName] = resolvedVersion;
   if (

diff --git a/packages/core/src/generators/sync/generator.ts b/packages/core/src/generators/sync/generator.ts
@@ -39,6 +39,7 @@ export default async function (host: Tree) {
               version,
               configuredVersion,
               false,
+              pkg,
             );
             // console.log('Resolved:', resolved)
             config.nugetPackages[pkg] = resolved;

diff --git a/packages/core/src/generators/sync/schema.json b/packages/core/src/generators/sync/schema.json
@@ -4,5 +4,6 @@
   "id": "Sync",
   "title": "",
   "type": "object",
+  "description": "Syncs package versions across the workspace with nx-dotnet config.",
   "properties": {}
 }
diff --git a/packages/core/src/generators/utils/resolve-version-mismatch.ts b/packages/core/src/generators/utils/resolve-version-mismatch.ts
@@ -6,6 +6,7 @@ export async function resolveVersionMismatch(
   desired: string | undefined,
   configured: string | undefined,
   allowVersionMismatch: boolean,
+  packageName: string | undefined,
 ): Promise<string> {
   if (configured) {
     if (configured !== desired) {
@@ -28,8 +29,9 @@ export async function resolveVersionMismatch(
                 short: 'Allow mismatch',
               },
             ],
-            message:
-              'There appears to be a mismatch between your current package preferences and the requested version. Which version would you like to use?',
+            message: `There appears to be a mismatch between your current package preferences and the requested version ${
+              packageName ? 'for ' + packageName : ''
+            }. Which version would you like to use?`,
           },
         ]);
         return resolution;
@@ -40,7 +42,9 @@ export async function resolveVersionMismatch(
       const { choice } = await prompt([
         {
           name: 'choice',
-          message: `You have not yet set a version for this package. Which version would you like to install?`,
+          message: `You have not yet set a version for ${
+            packageName ? packageName : 'this package'
+          }. Which version would you like to install?`,
         },
       ]);
       return choice;