fix(core): remove orphaned publish-local (#611)

- add steps for using sandbox in CONTRIBUTING.MD Co-authored-by: Chris Leigh <chris.leigh@sbdinc.com>
nx-dotnet · Feb 3, 2023 · 7985e14 · 7985e14
1 parent b3856e0
commit 7985e14
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 3 deletions.
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -42,3 +42,19 @@ We support the following scopes:
 
 - ci // improvements to the CI / CD pipelines.
 - repo // improvements to the general repository.
+
+### Development tips
+
+#### Validating plug-in changes locally
+
+The recommended way to validate your changes is to deploy the plugin locally to a fresh nx workspace.
+
+- A sandbox workspace can be generated via `yarn sandbox`
+- This script will build/publish the plugin to a sandbox workspace (./tmp/sandbox)
+- Verdaccio is leveraged to start a locally running instance of npm (http://localhost:4872)
+  - The server will close when the script is stopped
+- use `nx generate @nx-dotnet/core:[generator]` to validate your changes manually
+
+#### Unit testing
+
+To validate against the affected tests, use `nx affected:test`
diff --git a/package.json b/package.json
@@ -4,15 +4,14 @@
   "scripts": {
     "prepare": "husky install && nx g @nx-dotnet/core:restore",
     "lint-staged": "lint-staged",
-    "publish-dev": "ts-node tools/scripts/publish-dev",
     "e2e": "ts-node -P ./tools/scripts/tsconfig.e2e.json ./tools/scripts/e2e.ts",
-    "publish-local": "cp .npmrc.local .npmrc && run-p \"rimraf tmp\" e2e-registry \"ts-node ./tools/scripts/publish-all 99.99.99 local\"",
     "semantic-release": "semantic-release",
     "ts-node": "ts-node",
     "rimraf": "rimraf",
     "preinstall": "node ./tools/scripts/hooks/preinstall.js",
     "documentation:check": "ts-node ./tools/scripts/hooks/documentation.check.ts",
     "documentation": "nx g @nx-dotnet/nxdoc:generate-docs",
+    "publish-dev": "ts-node tools/scripts/publish-dev",
     "sandbox": "ts-node ./tools/scripts/sandbox.ts"
   },
   "private": false,

diff --git a/tools/scripts/sandbox.ts b/tools/scripts/sandbox.ts
@@ -35,7 +35,7 @@ if (require.main === module) {
   }
   ensureDirSync(dirname(sandboxDirectory));
   execSync(
-    `yarn create nx-workspace@latest ${basename(
+    `npx create-nx-workspace@latest ${basename(
       sandboxDirectory,
     )} --preset empty --no-nxCloud --packageManager yarn`,
     {