fix(core): aliases were not being picked up when generating projects …

…w/ solution files
nx-dotnet · Dec 14, 2021 · 56c770a · 56c770a
1 parent 3d91672
commit 56c770a
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 77 deletions.
diff --git a/docs/core/generators/app.md b/docs/core/generators/app.md
diff --git a/docs/core/generators/lib.md b/docs/core/generators/lib.md
diff --git a/docs/core/guides/handling-solutions.md b/docs/core/guides/handling-solutions.md
@@ -15,13 +15,19 @@ To add projects to a solution file by default, you can set the generator default
   // ... more nx.json configuration
   generators: {
     // ... other default configurations
-    '@nx-dotnet/core:app': {
+    '@nx-dotnet/core:application': {
       solutionFile: true,
     },
+    // ... other default configurations
+    '@nx-dotnet/core:library': {
+      solution: 'my-sln.sln',
+    },
   },
 }
 ```
 
+> Note that the generator names in `nx.json` must be the full name. Alias's like `app`, `lib` and so on will not be recognized.
+
 ## Subgraph Solutions
 
 In a large monorepo, IDEs or other tooling may slow down when presented with a large solution file. Currently, `nx-dotnet` does not assist in managing this issue, but there are a few easy steps to take that can help optimize your workflow. Which path you take will depend on both the tooling you use, and the pains that you are enountering.

diff --git a/packages/core/src/generators/app/schema.json b/packages/core/src/generators/app/schema.json
@@ -76,7 +76,7 @@
           "description": "Should the project be added to the default solution file?"
         }
       ],
-      "alias": ["solution", "s"]
+      "aliases": ["solution", "s"]
     }
   },
   "required": ["name", "template", "language"]

diff --git a/packages/core/src/generators/lib/schema.json b/packages/core/src/generators/lib/schema.json
@@ -70,7 +70,7 @@
           "description": "Should the project be added to the default solution file?"
         }
       ],
-      "alias": ["solution", "s"]
+      "aliases": ["solution", "s"]
     }
   },
   "required": ["name", "template", "language", "testTemplate"]