Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated to reflect current script output #1574

Merged
merged 1 commit into from
Jul 11, 2017
Merged

updated to reflect current script output #1574

merged 1 commit into from
Jul 11, 2017

Conversation

QuinnMallorry
Copy link
Contributor

No description provided.

@ljharb ljharb added informational installing nvm Problems installing nvm itself labels Jul 11, 2017
@ljharb ljharb merged commit b3bdbb2 into nvm-sh:master Jul 11, 2017
@QuinnMallorry QuinnMallorry deleted the patch-1 branch July 11, 2017 17:46
@PeterDaveHello
Copy link
Collaborator

PeterDaveHello commented Jul 12, 2017

I didn't directly do it when adding the bash completion script auto sourcing because we don't know if the user is using bash or not, this sourcing could have some strange outputs in non-bash.

@ljharb
Copy link
Member

ljharb commented Jul 12, 2017

hmm, that's a good point.

should we perhaps add a bailout to bash_completion? or should we revert this change?

@PeterDaveHello
Copy link
Collaborator

I prefer to move it to another codeblock with explanation that only users under bash needs to do that.

@ljharb
Copy link
Member

ljharb commented Jul 13, 2017

Sounds great; want to make that PR? :-D

@PeterDaveHello
Copy link
Collaborator

I thought we mentioned it here already: https://github.com/creationix/nvm#bash-completion, maybe don't need to duplicate it?

@ljharb
Copy link
Member

ljharb commented Jul 13, 2017

Sure, either way. We can wait and see if people end up being confused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
informational installing nvm Problems installing nvm itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants